From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/5] Linux: Add tables with system call numbers
Date: Tue, 31 Dec 2019 10:57:42 -0300 [thread overview]
Message-ID: <d880d250-39e5-e83f-4db8-7f2f864fa5a6@linaro.org> (raw)
In-Reply-To: <87zhf8n3j4.fsf@mid.deneb.enyo.de>
On 31/12/2019 08:22, Florian Weimer wrote:
> * Siddhesh Poyarekar:
>
>>> diff --git a/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h b/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h
>>> new file mode 100644
>>> index 0000000000..163f618499
>>> --- /dev/null
>>> +++ b/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h
>>
>> Prefix the auto-generated files with a comment header like so:
>>
>> /* AUTOGENERATED by update-syscall-lists.py. DO NOT EDIT. */
>
> I'm concerned that this unnecessarily makes processing by tools more
> difficult, so I'd like to avoid this.
But isn't the idea of the script to always regenerate the file? I see this
kind of warning valuable to guide either a developer or an user to find
into the generation tools instead of hack the file itself for possible
solutions.
Rest looks ok to me, I would maybe extend the commit message to add the
information from cover-letter on how to fully update the arch-syscall.h
table once a new kernel is released.
Thanks for working on this, this decouple is something I would like to
push on glibc.
next prev parent reply other threads:[~2019-12-31 13:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 14:30 [PATCH 0/5] Implement built-in system call tables Florian Weimer
2019-12-17 14:30 ` [PATCH 1/5] Linux: Add tables with system call numbers Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-31 11:22 ` Florian Weimer
2019-12-31 13:57 ` Adhemerval Zanella [this message]
2019-12-31 16:48 ` Florian Weimer
2019-12-31 15:50 ` Siddhesh Poyarekar
2019-12-31 16:04 ` Florian Weimer
2019-12-31 16:11 ` Siddhesh Poyarekar
2019-12-31 17:43 ` Florian Weimer
2019-12-31 20:51 ` Florian Weimer
2020-01-02 5:55 ` Siddhesh Poyarekar
2020-01-02 9:22 ` Florian Weimer
2019-12-17 14:30 ` [PATCH 2/5] Linux: Use system call tables during build Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:30 ` [PATCH 3/5] build-many-glibcs.py: Introduce LinuxHeadersPolicyForBuild Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:31 ` [PATCH 4/5] build-many-glibcs.py: Introduce glibc build policy classes Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:31 ` [PATCH 5/5] build-many-glibcs.py: Implement update-syscalls command Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2020-01-01 10:35 ` [PATCH 0/5] Implement built-in system call tables Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d880d250-39e5-e83f-4db8-7f2f864fa5a6@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).