From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/5] Linux: Add tables with system call numbers
Date: Thu, 2 Jan 2020 11:25:21 +0530 [thread overview]
Message-ID: <1883b9f8-d818-fae1-f246-18b8bff70dc5@gotplt.org> (raw)
In-Reply-To: <875zhwl7ax.fsf@mid.deneb.enyo.de>
On 31/12/19 11:13 pm, Florian Weimer wrote:
> * Siddhesh Poyarekar:
>
>> On 31/12/19 9:34 pm, Florian Weimer wrote:
>>> I'll see what I can do about this. It will require quite a bit
>>> re-testing.
>>>
>>
>> Thanks, the freeze (I'm evaluating and writing that email as I write
>> this) will be slushy at least till the end of this week. At worst (i.e.
>> if you can't make it by the end of the week), we can conclude the review
>> and you can commit it right after release.
>>
>>> No, there are system call tables which are shared across tuples,
>>> e.g. little-endian and big-endian variants. These also get updated
>>> multiple times.
>>>
>>> The only alternative would be to lock a different file, perhaps
>>> sysdeps/unix/sysv/linux/Makefile. I don't know the impact yet on the
>>> execution time.
>>
>> OK, we can hold off on that, the current version of this bit is fine.
>
> Here's a new version of the patch, with the file comment and the
> atomic file replacement.
>
Thank you, this looks good to me. Please commit the patchset before end
of your day on Friday.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
next prev parent reply other threads:[~2020-01-02 5:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 14:30 [PATCH 0/5] Implement built-in system call tables Florian Weimer
2019-12-17 14:30 ` [PATCH 1/5] Linux: Add tables with system call numbers Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-31 11:22 ` Florian Weimer
2019-12-31 13:57 ` Adhemerval Zanella
2019-12-31 16:48 ` Florian Weimer
2019-12-31 15:50 ` Siddhesh Poyarekar
2019-12-31 16:04 ` Florian Weimer
2019-12-31 16:11 ` Siddhesh Poyarekar
2019-12-31 17:43 ` Florian Weimer
2019-12-31 20:51 ` Florian Weimer
2020-01-02 5:55 ` Siddhesh Poyarekar [this message]
2020-01-02 9:22 ` Florian Weimer
2019-12-17 14:30 ` [PATCH 2/5] Linux: Use system call tables during build Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:30 ` [PATCH 3/5] build-many-glibcs.py: Introduce LinuxHeadersPolicyForBuild Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:31 ` [PATCH 4/5] build-many-glibcs.py: Introduce glibc build policy classes Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:31 ` [PATCH 5/5] build-many-glibcs.py: Implement update-syscalls command Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2020-01-01 10:35 ` [PATCH 0/5] Implement built-in system call tables Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1883b9f8-d818-fae1-f246-18b8bff70dc5@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).