From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/5] Linux: Use system call tables during build
Date: Sat, 28 Dec 2019 18:09:44 +0530 [thread overview]
Message-ID: <5983972e-ea89-c338-e2ac-22f79ae0df09@gotplt.org> (raw)
In-Reply-To: <5aac813374bb5ec506c7bc3afe68eae55f783e42.1576588849.git.fweimer@redhat.com>
On 17/12/19 8:00 pm, Florian Weimer wrote:
> Use <arch-syscall.h> instead of <asm/unistd.h> to obtain the system
> call numbers. A few direct includes of <asm/unistd.h> need to be
> removed (if the system call numbers are already provided indirectly
> by <sysdep.h>) or replaced with <sys/syscall.h>.
>
> Current Linux headers for alpha define the required system call names,
> so most of the _NR_* hacks are no longer needed. For the 32-bit arm
> architecture, eliminate the INTERNAL_SYSCALL_ARM macro, now that we
> have regular system call names for cacheflush and set_tls. There are
> more such cleanup opportunities for other architectures, but these
> cleanups are required to avoid macro redefinition errors during the
> build.
>
> For ia64, it is desirable to use <asm/break.h> directly to obtain
> the break number for system calls (which is not a system call number
> itself). This requires replacing __BREAK_SYSCALL with
> __IA64_BREAK_SYSCALL because the former is defined as an alias in
> <asm/unistd.h>, but not in <asm/break.h>.
> ---
> NEWS | 3 +-
> sysdeps/ia64/start.S | 1 -
> sysdeps/microblaze/backtrace_linux.c | 2 +-
> .../unix/sysv/linux/alpha/kernel-features.h | 5 ----
> sysdeps/unix/sysv/linux/alpha/sysdep.h | 25 ----------------
> sysdeps/unix/sysv/linux/arm/dl-machine.h | 2 +-
> sysdeps/unix/sysv/linux/arm/sysdep.h | 4 ---
> sysdeps/unix/sysv/linux/arm/tls.h | 2 +-
> sysdeps/unix/sysv/linux/hppa/clone.S | 1 -
> sysdeps/unix/sysv/linux/ia64/brk.S | 1 -
> sysdeps/unix/sysv/linux/ia64/clone2.S | 4 +--
> sysdeps/unix/sysv/linux/ia64/syscall.S | 2 +-
> sysdeps/unix/sysv/linux/ia64/sysdep.S | 2 +-
> sysdeps/unix/sysv/linux/ia64/sysdep.h | 5 ++--
> sysdeps/unix/sysv/linux/include/sys/syscall.h | 29 +++++++++++++++++++
> sysdeps/unix/sysv/linux/mips/vfork.S | 1 -
> sysdeps/unix/sysv/linux/nios2/sysdep.h | 1 -
> sysdeps/unix/sysv/linux/riscv/flush-icache.c | 1 +
> sysdeps/unix/sysv/linux/sparc/sparc32/clone.S | 1 -
> sysdeps/unix/sysv/linux/sparc/sparc64/clone.S | 1 -
> sysdeps/unix/sysv/linux/sys/syscall.h | 11 +++----
> 21 files changed, 46 insertions(+), 58 deletions(-)
> create mode 100644 sysdeps/unix/sysv/linux/include/sys/syscall.h
This is OK.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
next prev parent reply other threads:[~2019-12-28 12:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 14:30 [PATCH 0/5] Implement built-in system call tables Florian Weimer
2019-12-17 14:30 ` [PATCH 1/5] Linux: Add tables with system call numbers Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-31 11:22 ` Florian Weimer
2019-12-31 13:57 ` Adhemerval Zanella
2019-12-31 16:48 ` Florian Weimer
2019-12-31 15:50 ` Siddhesh Poyarekar
2019-12-31 16:04 ` Florian Weimer
2019-12-31 16:11 ` Siddhesh Poyarekar
2019-12-31 17:43 ` Florian Weimer
2019-12-31 20:51 ` Florian Weimer
2020-01-02 5:55 ` Siddhesh Poyarekar
2020-01-02 9:22 ` Florian Weimer
2019-12-17 14:30 ` [PATCH 2/5] Linux: Use system call tables during build Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar [this message]
2019-12-17 14:30 ` [PATCH 3/5] build-many-glibcs.py: Introduce LinuxHeadersPolicyForBuild Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:31 ` [PATCH 4/5] build-many-glibcs.py: Introduce glibc build policy classes Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2019-12-17 14:31 ` [PATCH 5/5] build-many-glibcs.py: Implement update-syscalls command Florian Weimer
2019-12-28 12:39 ` Siddhesh Poyarekar
2020-01-01 10:35 ` [PATCH 0/5] Implement built-in system call tables Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5983972e-ea89-c338-e2ac-22f79ae0df09@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).