From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 72AAA1F463 for ; Tue, 31 Dec 2019 13:57:52 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=as03JIwf3Q27R5WS y8Y8fqmpCGxQ9AzCrcbLZONB9DH5jWNHqz8S3zP6OJWh/bjA5w4TT2IKsFoDzFZU Tf7w+Z7VgchOEleFrFz+niJfK5ul1qThAXARZJoGFxYjoDqy46/szAROKNVz9/OS YX7QL65JM8zsbUF9AlXsnYlKOoE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=TmFVpFJCRW4tNsByfpotwN CKZyo=; b=IYmLz8TgwIF5urL4wCzSnbsKaV63Wj+LXmUTQ9kqmRKUSvLJxz7XP/ dBUHX7eo/h7Y3Bc910YCuCfRqMQumTKbu29q0nfZkLovxUqDC0yzV2MAsJxnNAus 8qeh8QmOGSuVqG/CpwtsbMofR25cP0rPIuuN6ZlWutZXA5sVbdbLE= Received: (qmail 11702 invoked by alias); 31 Dec 2019 13:57:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11693 invoked by uid 89); 31 Dec 2019 13:57:49 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-pj1-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OOPN64QFNqdbpFgHl2mU5xsnyLo6trPV9j7FAD5wKRM=; b=hJ4eXpNSa+jOLmg9kGANBSf0opmIvCMAzB8ZC5DzwQsKbNd5p1l1AOrqg9qq9mkY72 SbZcW480ds1EG3QwkTdmHPEDXUrwTghT4ll8GAYe/RdP1KiiQg4GVmfSLZw9tX7WSUur JerLCc8/tjml0FzSBsh9wQ8uZYwZlMLAW0JkFyi7BUTKuCmH/mD/Ihj+YNOAbQ3SZKw2 dsmptOaLMlcICjH0A8p7vTzIJx67WzVMrL2oOqt5Vvlw/0kICjGgzf/yZjwhEs+OPFb2 cKjlRDI8LjP7cUepPOdisrROncG3MvyUQfXi/ruUGQhSSo6YcE0eLgPo7kJG/SPB7+wf wHaQ== To: libc-alpha@sourceware.org References: <56247f60-bee7-9624-37bf-1453c06c7088@gotplt.org> <87zhf8n3j4.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Subject: Re: [PATCH 1/5] Linux: Add tables with system call numbers Message-ID: Date: Tue, 31 Dec 2019 10:57:42 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87zhf8n3j4.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 31/12/2019 08:22, Florian Weimer wrote: > * Siddhesh Poyarekar: > >>> diff --git a/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h b/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h >>> new file mode 100644 >>> index 0000000000..163f618499 >>> --- /dev/null >>> +++ b/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h >> >> Prefix the auto-generated files with a comment header like so: >> >> /* AUTOGENERATED by update-syscall-lists.py. DO NOT EDIT. */ > > I'm concerned that this unnecessarily makes processing by tools more > difficult, so I'd like to avoid this. But isn't the idea of the script to always regenerate the file? I see this kind of warning valuable to guide either a developer or an user to find into the generation tools instead of hack the file itself for possible solutions. Rest looks ok to me, I would maybe extend the commit message to add the information from cover-letter on how to fully update the arch-syscall.h table once a new kernel is released. Thanks for working on this, this decouple is something I would like to push on glibc.