unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Wolfgang Denk <wd@denx.de>
Cc: <libc-alpha@sourceware.org>, Lukasz Majewski <lukma@denx.de>
Subject: Re: Accelerating Y2038 glibc fixes
Date: Thu, 25 Jul 2019 19:54:32 +0000	[thread overview]
Message-ID: <alpine.DEB.2.21.1907251934270.17883@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20190712072103.D3DBC24003A@gemini.denx.de>

On Fri, 12 Jul 2019, Wolfgang Denk wrote:

> See for example [1] - there are just 7 lines of "code".  But Joseph
> does not accept our patches.  The arguments he gives are not on a
> technical level;

The patch is providing a technical specification that is supposed to 
underpin both subsequent patches in the series and maintenance of code in 
this area of glibc over several years - an area where complete clarity of 
the intended interface is critical.  That the specification in question is 
seriously vague with emphasis on the wrong concepts is very much a 
technical issue.  The code is very much the easiest and least important 
part of this patch.

> instead he says that only a native English speaker
> who has a with deep understanding of glibc internals and the
> previous development process will be capable to provide such a patch
> in an acceptable way.

That is not what I said.  I said it makes more sense for someone with that 
familiarity to do the editing - that is, that would enable the 
specification to achieve consensus sooner than going through a long 
sequence of patch reviews.

Writing detailed, precise explanations of exactly how something vague is 
vague and how the concepts referenced aren't quite the right ones is 
itself very time-consuming (listing all the deficiencies in a sentence 
such as "To be more specific - this flag focuses on higer level of 
abstraction, which indicates the system's ability to support 64 bit time." 
in the specification would result in an enumeration much longer than that 
sentence itself), but if you'd rather proceed with such reviews we can do 
so.  Based on previous experience with reviews of patches in this series, 
that would likely take several more iterations to get a specification of 
reasonable quality than simply rewriting the text in question.

> [1] https://patchwork.ozlabs.org/patch/1114061/

This is not the most recent version of the patch posted.

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2019-07-25 19:54 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  7:21 Accelerating Y2038 glibc fixes Wolfgang Denk
2019-07-16  9:32 ` Wolfgang Denk
2019-07-16 11:50 ` Siddhesh Poyarekar
2019-07-16 12:40   ` Wolfgang Denk
2019-07-16 12:44 ` Florian Weimer
2019-07-16 14:52   ` Wolfgang Denk
2019-07-16 15:09     ` Florian Weimer
2019-07-16 15:19       ` Andrew Pinski
2019-07-17 14:15     ` Arnd Bergmann
2019-07-17 14:41       ` Florian Weimer
2019-07-17 16:00         ` Wolfgang Denk
2019-07-17 16:04           ` Florian Weimer
2019-07-17 16:18             ` Lukasz Majewski
2019-07-18 18:53               ` Adhemerval Zanella
2019-07-18 19:13                 ` Florian Weimer
2019-07-18 20:31                   ` Adhemerval Zanella
2019-07-18 21:20                     ` Florian Weimer
2019-07-18 22:32                     ` Paul Eggert
2019-07-19  7:21                       ` Andreas Schwab
2019-07-19  3:06                     ` Rich Felker
2019-07-19 17:44                       ` Adhemerval Zanella
2019-07-19 19:03                         ` Alistair Francis
2019-07-25 20:40                 ` Joseph Myers
2019-07-29 17:47                   ` Adhemerval Zanella
2019-07-29 19:58                     ` Joseph Myers
2019-07-29 21:00                       ` Adhemerval Zanella
2019-07-29 21:08                         ` Joseph Myers
2019-07-29 23:12                           ` Paul Eggert
2019-07-29 23:30                             ` Joseph Myers
2019-07-17 17:50       ` Rich Felker
2019-07-17 21:57         ` Lukasz Majewski
2019-07-17 22:37           ` Rich Felker
2019-07-18  7:20             ` Lukasz Majewski
2019-07-18 13:35               ` Rich Felker
2019-07-18 14:47           ` Rich Felker
2019-07-18 14:49             ` Florian Weimer
2019-07-18 15:46               ` Rich Felker
2019-07-18 16:43                 ` Adhemerval Zanella
2019-07-20  4:43             ` Rich Felker
2019-07-25 19:54 ` Joseph Myers [this message]
2019-07-26 10:39   ` Lukasz Majewski
2019-07-29 18:55     ` Zack Weinberg
2019-07-29 20:12       ` Joseph Myers
2019-07-30 11:02         ` Lukasz Majewski
2019-07-30 12:24           ` Joseph Myers
2019-07-30 14:04       ` Lukasz Majewski
2019-08-09  7:25         ` Lukasz Majewski
     [not found]           ` <CAKCAbMhOMQ9yTFpy+OQkDvZPPFf_fFn6oSxjvLTaUwC4jpPRag@mail.gmail.com>
2019-08-09 12:32             ` Fwd: " Zack Weinberg
2019-07-30 19:58       ` Joseph Myers
2019-07-30 20:28         ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1907251934270.17883@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).