From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 310041F97E for ; Thu, 25 Jul 2019 19:54:44 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=IK9JX fYZ1EBApajQUegL9wNp2gJVYW7ORCGcIUsaJgC8o2/5MpFYpN45kCWXrNZqwO0Ln qi3/COHVYegiPw1EkqSSrM/rOgdIG0EN9PJNBEOZZZI7hBWbQ6lvwLloa3uyWVI0 N1M5BGpZcA5fbZ8etgO+0bp0eFkA7uCuJoGiow= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=t2uvukZ2a2M 9RdRBvj/nCLOsEq0=; b=XrI2Q4qOeteZXcuyPG9LS/HhOXy9keESs4pyVksoJsw nPk32Ts0q3/QcqVR1rJ/J6fN2jaM43KE5aliFhhPMr1AFRBsdYkGUwKhrsoYUiRJ LPIy4tRUdYKoTFbZnn8idxryCiRjDxguJn+ODy1fOUzmBRo0MRAtDhaJrsNx3RC4 = Received: (qmail 78113 invoked by alias); 25 Jul 2019 19:54:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 78104 invoked by uid 89); 25 Jul 2019 19:54:41 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Thu, 25 Jul 2019 19:54:32 +0000 From: Joseph Myers To: Wolfgang Denk CC: , Lukasz Majewski Subject: Re: Accelerating Y2038 glibc fixes In-Reply-To: <20190712072103.D3DBC24003A@gemini.denx.de> Message-ID: References: <20190712072103.D3DBC24003A@gemini.denx.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Fri, 12 Jul 2019, Wolfgang Denk wrote: > See for example [1] - there are just 7 lines of "code". But Joseph > does not accept our patches. The arguments he gives are not on a > technical level; The patch is providing a technical specification that is supposed to underpin both subsequent patches in the series and maintenance of code in this area of glibc over several years - an area where complete clarity of the intended interface is critical. That the specification in question is seriously vague with emphasis on the wrong concepts is very much a technical issue. The code is very much the easiest and least important part of this patch. > instead he says that only a native English speaker > who has a with deep understanding of glibc internals and the > previous development process will be capable to provide such a patch > in an acceptable way. That is not what I said. I said it makes more sense for someone with that familiarity to do the editing - that is, that would enable the specification to achieve consensus sooner than going through a long sequence of patch reviews. Writing detailed, precise explanations of exactly how something vague is vague and how the concepts referenced aren't quite the right ones is itself very time-consuming (listing all the deficiencies in a sentence such as "To be more specific - this flag focuses on higer level of abstraction, which indicates the system's ability to support 64 bit time." in the specification would result in an enumeration much longer than that sentence itself), but if you'd rather proceed with such reviews we can do so. Based on previous experience with reviews of patches in this series, that would likely take several more iterations to get a specification of reasonable quality than simply rewriting the text in question. > [1] https://patchwork.ozlabs.org/patch/1114061/ This is not the most recent version of the patch posted. -- Joseph S. Myers joseph@codesourcery.com