From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Joseph Myers <josmyers@redhat.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 03/10] i386: Use generic fmod
Date: Thu, 28 Mar 2024 16:37:29 -0300 [thread overview]
Message-ID: <a90fdb0c-79d9-4686-9f5c-84568a43f29b@linaro.org> (raw)
In-Reply-To: <581bcd44-11eb-5dc4-de67-8de9e23435@redhat.com>
On 28/03/24 15:38, Joseph Myers wrote:
> On Thu, 28 Mar 2024, Adhemerval Zanella Netto wrote:
>
>> We don't really have SVID compatibility tests for any other
>> optimization/simplification, and although I don't really oppose on
>> adding I also thinking that this is making this change even more
>> complicated than it would require.
>
> We have math/test-matherr* as generic tests of matherr working with
> binaries that specifically use the compat symbol matherr and not with
> newly linked binaries. Those don't however attempt to test properties of
> specific symbols for individual libm functions.
I meant that we don't have explicit SVID tests that check its semantic
(including return code, matherr status, stdout return code), like we do
for some compat symbols. And I took that this what H.J is asking about.
>
> A change like the present one is not meant to be user-visible for any
> newly linked binary, as a legitimate newly linked binary couldn't link
> against the matherr compat symbol anyway. And we don't have any attempt
> to ensure that old symbol versions of individual libm functions can be
> used together with the compat symbol of matherr - just that the compat
> symbol of matherr works with one libm function.
>
next prev parent reply other threads:[~2024-03-28 19:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:40 [PATCH v2 00/10] Fix some libm static issues Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 01/10] math: Add support for auto static math tests Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 02/10] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488) Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 03/10] i386: Use generic fmod Adhemerval Zanella
2024-03-27 19:55 ` H.J. Lu
2024-03-27 20:37 ` Adhemerval Zanella Netto
2024-03-27 21:38 ` H.J. Lu
2024-03-28 14:11 ` Adhemerval Zanella Netto
2024-03-28 14:51 ` H.J. Lu
2024-03-28 15:14 ` Adhemerval Zanella Netto
[not found] ` <CAMe9rOqhQDA-zk=+oTvdoPpq=rGEhtan0couaZ3Z_fxeFpa=7A@mail.gmail.com>
[not found] ` <9bf7af32-afa3-439c-84c0-76e76b220e44@linaro.org>
[not found] ` <CAMe9rOqTcmRc9mvguQnDRFb=BTjZJ5CptxjtPjtBGoB-a5mc6Q@mail.gmail.com>
[not found] ` <0e4733a3-d569-4a73-b2d3-001cc6c3d751@linaro.org>
2024-03-28 16:00 ` H.J. Lu
2024-03-28 18:22 ` Adhemerval Zanella Netto
2024-03-28 18:38 ` Joseph Myers
2024-03-28 19:37 ` Adhemerval Zanella Netto [this message]
2024-03-28 19:57 ` H.J. Lu
2024-03-27 19:40 ` [PATCH v2 04/10] i386: Use generic fmodf Adhemerval Zanella
2024-03-27 19:55 ` H.J. Lu
2024-03-27 19:40 ` [PATCH v2 05/10] math: Fix i386 and m68k exp10 on static build Adhemerval Zanella
2024-03-27 19:57 ` H.J. Lu
2024-03-27 20:39 ` Adhemerval Zanella Netto
2024-03-27 20:55 ` Joseph Myers
2024-03-27 19:40 ` [PATCH v2 06/10] i386: Use generic exp10 Adhemerval Zanella
2024-03-27 20:14 ` H.J. Lu
2024-03-27 19:40 ` [PATCH v2 07/10] math: Fix isnanf128 static build Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 08/10] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 09/10] math: Provide frexpf128 " Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 10/10] math: Provide modf128 " Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90fdb0c-79d9-4686-9f5c-84568a43f29b@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=josmyers@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).