From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, Joseph Myers <josmyers@redhat.com>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v2 05/10] math: Fix i386 and m68k exp10 on static build
Date: Wed, 27 Mar 2024 12:57:51 -0700 [thread overview]
Message-ID: <CAMe9rOoSNK6bP9SqvxgtYwseXf5xwtkMz_y-qKThY-98JNxAqg@mail.gmail.com> (raw)
In-Reply-To: <20240327194024.1409677-6-adhemerval.zanella@linaro.org>
On Wed, Mar 27, 2024 at 12:40 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> The commit 08ddd26814 removed the static exp10 on i386 and m68k with an
> empty w_exp10.c (required for the ABIs that uses the newly
> implementation). This patch fixes by adding the required symbols on the
> arch-specific w_exp{f}_compat.c implementation.
>
> Checked on i686-linux-gnu and with a build for m68k-linux-gnu.
> ---
> math/Makefile | 4 +++-
> sysdeps/i386/fpu/w_exp10_compat.c | 9 +++++++--
> sysdeps/m68k/m680x0/fpu/w_exp10_compat.c | 9 +++++++--
> 3 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/math/Makefile b/math/Makefile
> index 964bf2be71..f1d210797d 100644
> --- a/math/Makefile
> +++ b/math/Makefile
> @@ -367,7 +367,9 @@ $(libm-test-c-narrow-obj): $(objpfx)libm-test%.c: libm-test%.inc \
> $(PYTHON) gen-libm-test.py -c $< -a auto-libm-test-out$* -C $@
>
>
> -libm-test-funcs-auto-static =
> +libm-test-funcs-auto-static = \
> + exp10 \
> + # libm-test-funcs-auto-static
This doesn't provide confidence that static libm issues are fixed.
I think we should add a configure option to enable static tests for
all libm functions.
> libm-test-funcs-noauto-static = \
> fmod \
> # libm-test-funcs-noauto-static
> diff --git a/sysdeps/i386/fpu/w_exp10_compat.c b/sysdeps/i386/fpu/w_exp10_compat.c
> index b53455386e..49a0e03385 100644
> --- a/sysdeps/i386/fpu/w_exp10_compat.c
> +++ b/sysdeps/i386/fpu/w_exp10_compat.c
> @@ -1,3 +1,8 @@
> /* i386 provides an optimized __ieee754_exp10. */
> -#define NO_COMPAT_NEEDED 1
> -#include <math/w_exp10_compat.c>
> +#ifdef SHARED
> +# define NO_COMPAT_NEEDED 1
> +# include <math/w_exp10_compat.c>
> +#else
> +# include <math-type-macros-double.h>
> +# include <w_exp10_template.c>
> +#endif
> diff --git a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c
> index 0d3e718626..350f2e4b4d 100644
> --- a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c
> +++ b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c
> @@ -1,3 +1,8 @@
> /* m68k provides an optimized __ieee754_exp10. */
> -#define NO_COMPAT_NEEDED 1
> -#include <math/w_exp10_compat.c>
> +#ifdef SHARED
> +# define NO_COMPAT_NEEDED 1
> +# include <math/w_exp10_compat.c>
> +#else
> +# include <math-type-macros-double.h>
> +# include <w_exp10_template.c>
> +#endif
> --
> 2.34.1
>
--
H.J.
next prev parent reply other threads:[~2024-03-27 19:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:40 [PATCH v2 00/10] Fix some libm static issues Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 01/10] math: Add support for auto static math tests Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 02/10] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488) Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 03/10] i386: Use generic fmod Adhemerval Zanella
2024-03-27 19:55 ` H.J. Lu
2024-03-27 20:37 ` Adhemerval Zanella Netto
2024-03-27 21:38 ` H.J. Lu
2024-03-28 14:11 ` Adhemerval Zanella Netto
2024-03-28 14:51 ` H.J. Lu
2024-03-28 15:14 ` Adhemerval Zanella Netto
[not found] ` <CAMe9rOqhQDA-zk=+oTvdoPpq=rGEhtan0couaZ3Z_fxeFpa=7A@mail.gmail.com>
[not found] ` <9bf7af32-afa3-439c-84c0-76e76b220e44@linaro.org>
[not found] ` <CAMe9rOqTcmRc9mvguQnDRFb=BTjZJ5CptxjtPjtBGoB-a5mc6Q@mail.gmail.com>
[not found] ` <0e4733a3-d569-4a73-b2d3-001cc6c3d751@linaro.org>
2024-03-28 16:00 ` H.J. Lu
2024-03-28 18:22 ` Adhemerval Zanella Netto
2024-03-28 18:38 ` Joseph Myers
2024-03-28 19:37 ` Adhemerval Zanella Netto
2024-03-28 19:57 ` H.J. Lu
2024-03-27 19:40 ` [PATCH v2 04/10] i386: Use generic fmodf Adhemerval Zanella
2024-03-27 19:55 ` H.J. Lu
2024-03-27 19:40 ` [PATCH v2 05/10] math: Fix i386 and m68k exp10 on static build Adhemerval Zanella
2024-03-27 19:57 ` H.J. Lu [this message]
2024-03-27 20:39 ` Adhemerval Zanella Netto
2024-03-27 20:55 ` Joseph Myers
2024-03-27 19:40 ` [PATCH v2 06/10] i386: Use generic exp10 Adhemerval Zanella
2024-03-27 20:14 ` H.J. Lu
2024-03-27 19:40 ` [PATCH v2 07/10] math: Fix isnanf128 static build Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 08/10] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 09/10] math: Provide frexpf128 " Adhemerval Zanella
2024-03-27 19:40 ` [PATCH v2 10/10] math: Provide modf128 " Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoSNK6bP9SqvxgtYwseXf5xwtkMz_y-qKThY-98JNxAqg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=josmyers@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).