From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 334111F44D for ; Wed, 27 Mar 2024 19:58:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dS42ZfgK; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B3723858012 for ; Wed, 27 Mar 2024 19:58:49 +0000 (GMT) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id 6294D3858D20 for ; Wed, 27 Mar 2024 19:58:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6294D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6294D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711569509; cv=none; b=cl7Hi41Nv78IhTugoqATj26QkCBiH++eb/wHM3r82FKzwuJD2+ZKWc2AwNWSc4orCjkcgDWSn/BygBziOtROOXa+d6b0uRvU0tC9tVkZz7CjPI/Nce43+9IO3NVReE/zDkoq42WqZEykcLmB5zY2Z3OlAbo2A8U0VwVfK6Vyi0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711569509; c=relaxed/simple; bh=8px8835BuFzfpb/WXD+hZ5dkt7dX/Cgm/35tLtId0Wg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=hQjMZ1rP54VNe3VHEWjhPvG5dwOCZRbMkb6ZfAxUXvyKszF433qN9jvAcESPahihDukUVgaCsW8K2Qzp7i4wgT2a6kkeWaxYKN6PkEZ/Bkwn+oijl2Fp5HqTF6aqD3Vv+jmQ8zvqD+ugt+mKAJuZGzIoH3GfIVentngTXVa3uMk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-60a434ea806so2124757b3.3 for ; Wed, 27 Mar 2024 12:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711569507; x=1712174307; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QVsiUIUU0d0ZCXkHIIRxDeOEkm6E8FPjtYCgRQyZIe0=; b=dS42ZfgKRwGAwLCMdmmL9Cw9+fpJAyl8u4CWaHjJbpOjj3fC2sCQX48dnCAwshIHJA 2cQIiAH19JL/GTJod0Ha9RK06OPAm3kx0Lj8Ek24Ip9ifog4gRAlW8XWV3v8Ydr5TdT4 sds5G0pYCdTWCFDcSUGYrbKfzC4RmiO8AK9oKxurAxyZLhZWDdjz6u+iRuKlwgTICs9/ avmxkGEInDQ/rF7t3fcyLzdbRqKwU/ukIaeWrh5wh+PLem4D0L75f/NRtEdM2fIoz84C I+o609SEywHg9gr15nPrzqdxos4EwSNz3WUJZ5vF8NrWEHOOm5Nk6CZXMh6Er69ZMp1Y AEkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711569507; x=1712174307; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QVsiUIUU0d0ZCXkHIIRxDeOEkm6E8FPjtYCgRQyZIe0=; b=ARrcDul8J3jGJG3gtJ7MyFCPI1w3gVvb6jykLt85PD09LrVNRTJgJskUmQL8INUT2/ YcCCmiiuqAaUKYZDjV8bpiKEj9Hy97D8utqao9/IdYEJdyYbjcRVvL0WKo0z/u6StVBH YHoJGbU/KmFd24uSMCK9jwhxYhp4dBiF8JNcfvdRgI5VMkhacU5LPzaginw8yqKYegCe 3GeQi3KbqdcuEjABO3CRWpul/r62Z4xiZehpzDuv7uvk7w1+eKR4HBE7pPTn9Pe5sXIn XGvBLtq+MOG+m/6gw8DaC1CX4h5WSXtQ09Uky9HEBVJPcjEoIg/2FHLFXQJBLY2o59Fg 9+KQ== X-Gm-Message-State: AOJu0Yygur7KzPbViLoNaW/alVUbNvx8WDYp+KLsuliQVACzKn+Y57Bh 3qiS7+H/Ex2eSB2fQCoCC6TT73Djp0/FLUJv3p4mM93Kg3bgHKHz0zhY9GH74boRhF5caRbLwIT eIYkfiWbpKKFTyFd5ozgnVhzIg7yQgjgz X-Google-Smtp-Source: AGHT+IF9bB/3BTCoCXePs0fModrdBEXfVts5whrO2hP/ufgJGS1se7+rks0Zw/5bYPLcnIAxAPlmK6NDiAjckANGbWQ= X-Received: by 2002:a0d:e045:0:b0:610:bc71:43ab with SMTP id j66-20020a0de045000000b00610bc7143abmr678117ywe.44.1711569507694; Wed, 27 Mar 2024 12:58:27 -0700 (PDT) MIME-Version: 1.0 References: <20240327194024.1409677-1-adhemerval.zanella@linaro.org> <20240327194024.1409677-6-adhemerval.zanella@linaro.org> In-Reply-To: <20240327194024.1409677-6-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Wed, 27 Mar 2024 12:57:51 -0700 Message-ID: Subject: Re: [PATCH v2 05/10] math: Fix i386 and m68k exp10 on static build To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Wed, Mar 27, 2024 at 12:40=E2=80=AFPM Adhemerval Zanella wrote: > > The commit 08ddd26814 removed the static exp10 on i386 and m68k with an > empty w_exp10.c (required for the ABIs that uses the newly > implementation). This patch fixes by adding the required symbols on the > arch-specific w_exp{f}_compat.c implementation. > > Checked on i686-linux-gnu and with a build for m68k-linux-gnu. > --- > math/Makefile | 4 +++- > sysdeps/i386/fpu/w_exp10_compat.c | 9 +++++++-- > sysdeps/m68k/m680x0/fpu/w_exp10_compat.c | 9 +++++++-- > 3 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/math/Makefile b/math/Makefile > index 964bf2be71..f1d210797d 100644 > --- a/math/Makefile > +++ b/math/Makefile > @@ -367,7 +367,9 @@ $(libm-test-c-narrow-obj): $(objpfx)libm-test%.c: lib= m-test%.inc \ > $(PYTHON) gen-libm-test.py -c $< -a auto-libm-test-out$* -C $@ > > > -libm-test-funcs-auto-static =3D > +libm-test-funcs-auto-static =3D \ > + exp10 \ > + # libm-test-funcs-auto-static This doesn't provide confidence that static libm issues are fixed. I think we should add a configure option to enable static tests for all libm functions. > libm-test-funcs-noauto-static =3D \ > fmod \ > # libm-test-funcs-noauto-static > diff --git a/sysdeps/i386/fpu/w_exp10_compat.c b/sysdeps/i386/fpu/w_exp10= _compat.c > index b53455386e..49a0e03385 100644 > --- a/sysdeps/i386/fpu/w_exp10_compat.c > +++ b/sysdeps/i386/fpu/w_exp10_compat.c > @@ -1,3 +1,8 @@ > /* i386 provides an optimized __ieee754_exp10. */ > -#define NO_COMPAT_NEEDED 1 > -#include > +#ifdef SHARED > +# define NO_COMPAT_NEEDED 1 > +# include > +#else > +# include > +# include > +#endif > diff --git a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c b/sysdeps/m68k/m680= x0/fpu/w_exp10_compat.c > index 0d3e718626..350f2e4b4d 100644 > --- a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c > +++ b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c > @@ -1,3 +1,8 @@ > /* m68k provides an optimized __ieee754_exp10. */ > -#define NO_COMPAT_NEEDED 1 > -#include > +#ifdef SHARED > +# define NO_COMPAT_NEEDED 1 > +# include > +#else > +# include > +# include > +#endif > -- > 2.34.1 > --=20 H.J.