From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 40D981F44D for ; Thu, 28 Mar 2024 19:37:55 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=pcGJRB78; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 964A73858C78 for ; Thu, 28 Mar 2024 19:37:54 +0000 (GMT) Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 23EFD3858D1E for ; Thu, 28 Mar 2024 19:37:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23EFD3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 23EFD3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711654655; cv=none; b=ct7ypLagW2gVceWzse/0iupRVrWUIP5Xli58XTB5nGlUDuhjI97kaTOyLHVLG8Sa7Ow/bPQr1Qq9NMrBtH3XBhYb6Wp2+tf24D4/Sap+KJgOVytKxmPxNPq3j9beuKtSIhv/pMoMkf5iBcceJseqdJveldm6PwmNuQbqMbxuM9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711654655; c=relaxed/simple; bh=JEo6NI1m4pQYJIt8BzEw6vglUgolhEWFAIbvRusQVqM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GRsJ5UOMXewWRwq78qjsD3WCiVErq5Vh5HKkgBy8XQvBKBKvwWg2FieBEVBXdOI7iFTzYLc8AvGGpI6m0Lpdbv4I185urN9naGE4qHF+o2VajMCLAur665HslkXU+srWqzA9fk6QNuQbAXWg8FiKSr2OwzOVm4tBfZ4mfHwVVV0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7cc77c19a19so54953439f.2 for ; Thu, 28 Mar 2024 12:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711654653; x=1712259453; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Me53A41PAI38Cle3NPdPbo5SvbznBg0tGLjJiekJD94=; b=pcGJRB787G2yFd6XlPQ5KlMi7G8ccWaUROQBFPRfY9RYwr02B6Ly4wdxYGhV8s+4OG NjL0KeyF8gCp3/Hi6cJhGvS5nJqAGapidlAJ2Qr61JDq1cNPNmOT8lwKTz9uguHiN/ba SB2ePqHXJLbKcvJ2kuZoM+JGSFgdeKBo8rHaJ1EPJZ49D7KrgWysHWtKE+V9lS9UP+VP AyySDWnRxvbN/3hxOb6X6gjuwSnvVfajaOYCWaLq3aCirVoYiGh0wNS6+bsrfYm2lA7s TWT6kpjX95LVEIG6RU7lxxwlUYsaypJXs30h7IVXahqTJ5aYeTlypuOBrsOCfIq+s2GJ 5VpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711654653; x=1712259453; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Me53A41PAI38Cle3NPdPbo5SvbznBg0tGLjJiekJD94=; b=EHMOJmNd8G2xWMF7LHWcbhsmoaY0COe8kbWD+jtWu4k3jiua4bw3hdfWDcrl5zkCMW yY6vN71R4KiUgI1NsQmsY/h4r8TwNUY1KBAyKRVZE5LK/slnk9jgkkwBOlQaW09rI6n8 uypND+zZIMs+MdS62KhpXxKF3XmB/Z42D2nCn389BGOE+b03Dt/8AHvQ8exCSAd0SFCm hueabLAnpaPnkHpmsMWPgcA2F2n5ybeJgo9p6wqi6Lt8ORoTG9jlwZPiRTvbff2k20C5 97ZmYvvplQrWM37GAfGDPszZ8j34WdZovmtUM4zTL+uomqeyzEsINkyui7CVHrz61EXr dYMw== X-Forwarded-Encrypted: i=1; AJvYcCUNEfEgVVnNa309oB4TYXbfHzzGgorKt4ZM4M4FrrcT/pqwSZbz433DoLXTU6vn92GyKOwvwsRwvQ445fHAqtr3P8Uo/6o3cvxy X-Gm-Message-State: AOJu0Yz97sasyIboLhRoqWXfWp03/zt4V2OisNIpbktq4LJc6qBnxnTQ ZhAPPD0nhVdifFUJYXVoaA1sJi81ucHLjuKoH7YbyZLIYXI5ma9q9yXBniKdGY4= X-Google-Smtp-Source: AGHT+IHgdguv2mktLI14oU3pJ8eNBGFhJsoMaaY8NBHKf7boeBRY+k13ibkCk4TSeAo6W3xwVyklBQ== X-Received: by 2002:a05:6e02:1a04:b0:366:89b9:565c with SMTP id s4-20020a056e021a0400b0036689b9565cmr71311ild.15.1711654653228; Thu, 28 Mar 2024 12:37:33 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:b18e:f80b:dc91:dea1:d972? ([2804:1b3:a7c3:b18e:f80b:dc91:dea1:d972]) by smtp.gmail.com with ESMTPSA id e8-20020a63aa08000000b005d6b5934deesm1663619pgf.48.2024.03.28.12.37.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 12:37:32 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 16:37:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/10] i386: Use generic fmod To: Joseph Myers Cc: "H.J. Lu" , GNU C Library References: <20240327194024.1409677-1-adhemerval.zanella@linaro.org> <20240327194024.1409677-4-adhemerval.zanella@linaro.org> <1936623e-b6c1-40ef-b7c8-249eef54d071@linaro.org> <1048273f-c636-4c2b-83f6-7535839bce03@linaro.org> <9bf7af32-afa3-439c-84c0-76e76b220e44@linaro.org> <0e4733a3-d569-4a73-b2d3-001cc6c3d751@linaro.org> <1c27a80e-30f9-48fb-b608-8f2387621f5e@linaro.org> <581bcd44-11eb-5dc4-de67-8de9e23435@redhat.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <581bcd44-11eb-5dc4-de67-8de9e23435@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On 28/03/24 15:38, Joseph Myers wrote: > On Thu, 28 Mar 2024, Adhemerval Zanella Netto wrote: > >> We don't really have SVID compatibility tests for any other >> optimization/simplification, and although I don't really oppose on >> adding I also thinking that this is making this change even more >> complicated than it would require. > > We have math/test-matherr* as generic tests of matherr working with > binaries that specifically use the compat symbol matherr and not with > newly linked binaries. Those don't however attempt to test properties of > specific symbols for individual libm functions. I meant that we don't have explicit SVID tests that check its semantic (including return code, matherr status, stdout return code), like we do for some compat symbols. And I took that this what H.J is asking about. > > A change like the present one is not meant to be user-visible for any > newly linked binary, as a legitimate newly linked binary couldn't link > against the matherr compat symbol anyway. And we don't have any attempt > to ensure that old symbol versions of individual libm functions can be > used together with the compat symbol of matherr - just that the compat > symbol of matherr works with one libm function. >