From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: DJ Delorie <dj@redhat.com>
Cc: "carlos@redhat.com" <carlos@redhat.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH v2] Add malloc micro benchmark
Date: Wed, 3 Jan 2018 12:12:06 +0000 [thread overview]
Message-ID: <DB6PR0801MB2053B866BA86947A0D6B3D8A831E0@DB6PR0801MB2053.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <xnr2r86qwm.fsf@greed.delorie.com>
DJ Delorie wrote:
> What other tests do is create a second test that just #include's the
> first test, and set an environment variable in the Makefile specific to
> that test. Adding an ABI just for a test is a big hammer, although we
> could discuss adding tcache to mallopt() as a seperate topic.
Yeah but the makefiles are already insanely complex. Adding the new
benchmark to the makefile took more than 10x as much time as writing
the test itself...
> I don't have any objection to adding tcache to mallopt (although please
> add all three tunables if you do), just saying we should discuss it as
> an ABI change separately.
It doesn't have to be an external ABI, I'd suggest keeping this internal to
GLIBC to make testing and benchmarking easier.
Wilco
next prev parent reply other threads:[~2018-01-03 12:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 13:51 [PATCH] Add malloc micro benchmark Wilco Dijkstra
2017-12-01 16:13 ` Carlos O'Donell
2017-12-18 15:18 ` Wilco Dijkstra
2017-12-18 16:32 ` Carlos O'Donell
2018-01-02 18:20 ` [PATCH v2] " Wilco Dijkstra
2018-01-02 18:45 ` DJ Delorie
2018-01-03 12:12 ` Wilco Dijkstra [this message]
2018-01-03 15:07 ` Carlos O'Donell
2018-01-04 13:48 ` Wilco Dijkstra
2018-01-04 16:37 ` Adhemerval Zanella
2018-01-05 14:32 ` Carlos O'Donell
2018-01-05 15:50 ` Adhemerval Zanella
2018-01-05 16:17 ` Carlos O'Donell
2018-01-05 16:46 ` Adhemerval Zanella
2018-01-05 17:27 ` Carlos O'Donell
2018-01-05 14:33 ` Carlos O'Donell
2018-01-05 16:28 ` Joseph Myers
2018-01-05 17:26 ` Carlos O'Donell
2018-02-28 12:40 ` Florian Weimer
2018-02-28 14:11 ` Ondřej Bílka
2018-02-28 14:16 ` Florian Weimer
2018-02-28 16:16 ` Carlos O'Donell
2018-02-28 20:17 ` Ondřej Bílka
2018-02-28 16:46 ` Ondřej Bílka
2018-02-28 17:01 ` Wilco Dijkstra
2018-02-28 18:21 ` Carlos O'Donell
2018-02-28 19:56 ` Ondřej Bílka
2018-02-28 21:56 ` DJ Delorie
2018-03-01 11:24 ` Ondřej Bílka
2017-12-18 23:02 ` [PATCH] " DJ Delorie
2017-12-28 14:09 ` Wilco Dijkstra
2017-12-28 19:01 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0801MB2053B866BA86947A0D6B3D8A831E0@DB6PR0801MB2053.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).