unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Ondřej Bílka" <neleai@seznam.cz>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Joseph Myers <joseph@codesourcery.com>,
	Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
	"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	nd <nd@arm.com>
Subject: Re: [PATCH v2] Add malloc micro benchmark
Date: Wed, 28 Feb 2018 21:17:16 +0100	[thread overview]
Message-ID: <20180228201716.GA24825@domone> (raw)
In-Reply-To: <c5686c45-4922-f3d4-2204-852c0cd9b035@redhat.com>

On Wed, Feb 28, 2018 at 08:16:13AM -0800, Carlos O'Donell wrote:
> On 02/28/2018 06:16 AM, Florian Weimer wrote:
> > On 02/28/2018 03:11 PM, Ondřej Bílka wrote:
> >> Thats rather ineffective, it is easier to start fresh than try to 
> >> maintain rather obsolete allocator. Most of other are faster and
> >> more space effective because of their layout.
> > 
> > That's not quite true.  Despite its limitations, glibc malloc still
> > compares remarkably well to other allocators.  Of course, there are
> > workloads where it loses big, but those exist for other allocators,
> > too.  People simple don't write blog posts comparing *alloc with
> > glibc malloc if glibc malloc provides comparable or better
> > performance because it's quite boring.
> > 
> > I think a heap-style allocator which does not segregate allocations
> > of different sizes still has its place, and why not provide one in
> > glibc?
> 
> I agree.
> 
> I think an incremental improvement would be to start with some further
> code cleanups, all with the goal of simplifying the allocator maintenance.
>
You should like I did try to decruft implementation. I decided that
starting again is simpler after looking lot on existing how to do it. I
send some patches with decrufting but I found that with changing
algorithm, data structures mmap logic and basically everything else its
just unnecessary overhead.

You couldn't decrease data structure overhead without changing data
structure.
And for RSS size problem is in design that you couldn't return memory to
system. Large areas get pined by small allocations with return data and
you couldn't sbrk. It is needed to redesign it to unmap pages
individually.
Alternative would be to add something like malloca with separate arenas
for which existing logic works.


  reply	other threads:[~2018-02-28 20:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 13:51 [PATCH] Add malloc micro benchmark Wilco Dijkstra
2017-12-01 16:13 ` Carlos O'Donell
2017-12-18 15:18   ` Wilco Dijkstra
2017-12-18 16:32     ` Carlos O'Donell
2018-01-02 18:20       ` [PATCH v2] " Wilco Dijkstra
2018-01-02 18:45         ` DJ Delorie
2018-01-03 12:12           ` Wilco Dijkstra
2018-01-03 15:07             ` Carlos O'Donell
2018-01-04 13:48               ` Wilco Dijkstra
2018-01-04 16:37                 ` Adhemerval Zanella
2018-01-05 14:32                 ` Carlos O'Donell
2018-01-05 15:50                   ` Adhemerval Zanella
2018-01-05 16:17                     ` Carlos O'Donell
2018-01-05 16:46                       ` Adhemerval Zanella
2018-01-05 17:27                         ` Carlos O'Donell
2018-01-05 14:33         ` Carlos O'Donell
2018-01-05 16:28           ` Joseph Myers
2018-01-05 17:26             ` Carlos O'Donell
2018-02-28 12:40               ` Florian Weimer
2018-02-28 14:11                 ` Ondřej Bílka
2018-02-28 14:16                   ` Florian Weimer
2018-02-28 16:16                     ` Carlos O'Donell
2018-02-28 20:17                       ` Ondřej Bílka [this message]
2018-02-28 16:46                     ` Ondřej Bílka
2018-02-28 17:01                       ` Wilco Dijkstra
2018-02-28 18:21                         ` Carlos O'Donell
2018-02-28 19:56                         ` Ondřej Bílka
2018-02-28 21:56                           ` DJ Delorie
2018-03-01 11:24                             ` Ondřej Bílka
2017-12-18 23:02     ` [PATCH] " DJ Delorie
2017-12-28 14:09       ` Wilco Dijkstra
2017-12-28 19:01         ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228201716.GA24825@domone \
    --to=neleai@seznam.cz \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).