* [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory
@ 2019-03-07 16:33 Florian Weimer
2019-03-07 17:17 ` Zack Weinberg
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2019-03-07 16:33 UTC (permalink / raw)
To: libc-alpha
The check for "/finclude/" fails with the actual location of
Fortran headers because they are now stored in the "finclude"
subdirectory of the top-level include directory, so a relative path
does not contain a slash '/' before the "finclude" string.
2019-03-07 Florian Weimer <fweimer@redhat.com>
* scripts/check-wrapper-headers.py (check_headers): Adjust Fortran
header check.
diff --git a/scripts/check-wrapper-headers.py b/scripts/check-wrapper-headers.py
index dc9fd86063..bae99c14c7 100644
--- a/scripts/check-wrapper-headers.py
+++ b/scripts/check-wrapper-headers.py
@@ -76,7 +76,7 @@ def check_headers(args):
is_nonsysdep_header = os.access(header, os.R_OK)
if is_nonsysdep_header:
# Skip Fortran header files.
- if '/finclude/' in header:
+ if header.startswith("finclude/"):
continue
include_path = os.path.join(args.root, INCLUDE, header)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory
2019-03-07 16:33 [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory Florian Weimer
@ 2019-03-07 17:17 ` Zack Weinberg
2019-03-07 17:24 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Zack Weinberg @ 2019-03-07 17:17 UTC (permalink / raw)
To: Florian Weimer; +Cc: GNU C Library
On Thu, Mar 7, 2019 at 11:33 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> The check for "/finclude/" fails with the actual location of
> Fortran headers because they are now stored in the "finclude"
> subdirectory of the top-level include directory, so a relative path
> does not contain a slash '/' before the "finclude" string.
For future-proofing, the script should do both checks:
if header.startswith("finclude/") or "/finclude/" in header:
(I'm working on a patch series which, among other things, removes all
of the installed headers from the top-level include directory.)
zw
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory
2019-03-07 17:17 ` Zack Weinberg
@ 2019-03-07 17:24 ` Florian Weimer
2019-03-07 17:29 ` Zack Weinberg
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2019-03-07 17:24 UTC (permalink / raw)
To: Zack Weinberg; +Cc: GNU C Library
* Zack Weinberg:
> On Thu, Mar 7, 2019 at 11:33 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> The check for "/finclude/" fails with the actual location of
>> Fortran headers because they are now stored in the "finclude"
>> subdirectory of the top-level include directory, so a relative path
>> does not contain a slash '/' before the "finclude" string.
>
> For future-proofing, the script should do both checks:
>
> if header.startswith("finclude/") or "/finclude/" in header:
>
> (I'm working on a patch series which, among other things, removes all
> of the installed headers from the top-level include directory.)
This is the relative installed path, relative to the include directory,
which is put into the headers make variable.
I expect that Fortran headers will live exclusively in
/usr/include/finclude, which is why I'm not checking for finclude
subdirectories.
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory
2019-03-07 17:24 ` Florian Weimer
@ 2019-03-07 17:29 ` Zack Weinberg
0 siblings, 0 replies; 4+ messages in thread
From: Zack Weinberg @ 2019-03-07 17:29 UTC (permalink / raw)
To: Florian Weimer; +Cc: GNU C Library
On Thu, Mar 7, 2019 at 12:24 PM Florian Weimer <fweimer@redhat.com> wrote:
>
> This is the relative installed path, relative to the include directory,
> which is put into the headers make variable.
>
> I expect that Fortran headers will live exclusively in
> /usr/include/finclude, which is why I'm not checking for finclude
> subdirectories.
Oh, OK, that's fine then.
zw
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07 17:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 16:33 [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory Florian Weimer
2019-03-07 17:17 ` Zack Weinberg
2019-03-07 17:24 ` Florian Weimer
2019-03-07 17:29 ` Zack Weinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).