unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Zack Weinberg <zackw@panix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory
Date: Thu, 07 Mar 2019 18:24:16 +0100	[thread overview]
Message-ID: <87wola7g3j.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAKCAbMhhFxXvOtBRZGzWZvb=e7MULRU-QsgMCiqUMf-vZFb7Wg@mail.gmail.com> (Zack Weinberg's message of "Thu, 7 Mar 2019 12:17:24 -0500")

* Zack Weinberg:

> On Thu, Mar 7, 2019 at 11:33 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> The check for "/finclude/" fails with the actual location of
>> Fortran headers because they are now stored in the "finclude"
>> subdirectory of the top-level include directory, so a relative path
>> does not contain a slash '/' before the "finclude" string.
>
> For future-proofing, the script should do both checks:
>
>     if header.startswith("finclude/") or "/finclude/" in header:
>
> (I'm working on a patch series which, among other things, removes all
> of the installed headers from the top-level include directory.)

This is the relative installed path, relative to the include directory,
which is put into the headers make variable.

I expect that Fortran headers will live exclusively in
/usr/include/finclude, which is why I'm not checking for finclude
subdirectories.

Thanks,
Florian

  reply	other threads:[~2019-03-07 17:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 16:33 [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory Florian Weimer
2019-03-07 17:17 ` Zack Weinberg
2019-03-07 17:24   ` Florian Weimer [this message]
2019-03-07 17:29     ` Zack Weinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wola7g3j.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).