From: Zack Weinberg <zackw@panix.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory
Date: Thu, 7 Mar 2019 12:17:24 -0500 [thread overview]
Message-ID: <CAKCAbMhhFxXvOtBRZGzWZvb=e7MULRU-QsgMCiqUMf-vZFb7Wg@mail.gmail.com> (raw)
In-Reply-To: <20190307163306.B3E8F81D9FFB@oldenburg2.str.redhat.com>
On Thu, Mar 7, 2019 at 11:33 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> The check for "/finclude/" fails with the actual location of
> Fortran headers because they are now stored in the "finclude"
> subdirectory of the top-level include directory, so a relative path
> does not contain a slash '/' before the "finclude" string.
For future-proofing, the script should do both checks:
if header.startswith("finclude/") or "/finclude/" in header:
(I'm working on a patch series which, among other things, removes all
of the installed headers from the top-level include directory.)
zw
next prev parent reply other threads:[~2019-03-07 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 16:33 [PATCH COMMITTED] check-wrapper-headers test: Adjust Fortran include file directory Florian Weimer
2019-03-07 17:17 ` Zack Weinberg [this message]
2019-03-07 17:24 ` Florian Weimer
2019-03-07 17:29 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKCAbMhhFxXvOtBRZGzWZvb=e7MULRU-QsgMCiqUMf-vZFb7Wg@mail.gmail.com' \
--to=zackw@panix.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).