unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Zack Weinberg <zackw@panix.com>
To: DJ Delorie <dj@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
Date: Tue, 21 May 2019 10:04:15 -0400	[thread overview]
Message-ID: <CAKCAbMgNLB_AZ7H3CUsDOHhSnbst-kCjOsZvjEvJikk6-6x8jA@mail.gmail.com> (raw)
In-Reply-To: <xno93whrej.fsf@greed.delorie.com>

On Tue, May 21, 2019 at 9:24 AM DJ Delorie <dj@redhat.com> wrote:
>
> Florian Weimer <fweimer@redhat.com> writes:
> > Sorry, I don't understand.  Why would the user want to run distcc *in
> > the container*?
>
> That was just an example of an environment variable that affects the
> build.  I don't know what environment variables affect the test cases.
> Timeout-related?  Without a review of *every* test that might be run in
> a container, we won't know what environment variables are valid for the
> user to specify.

Maybe we should filter the environment, but have a mechanisme for
explicitly setting environment variables within the container?  For
instance, setting CONTAINER_ENVNAME=value could translate to
ENVNAME=value within the container.

zw

  reply	other threads:[~2019-05-21 14:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 17:40 [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH Florian Weimer
2019-05-20 18:19 ` DJ Delorie
2019-05-20 18:23   ` Florian Weimer
2019-05-20 19:26     ` DJ Delorie
2019-05-20 19:38       ` Florian Weimer
2019-05-21 12:49         ` DJ Delorie
2019-05-21 13:06           ` Florian Weimer
2019-05-21 13:24             ` DJ Delorie
2019-05-21 14:04               ` Zack Weinberg [this message]
2019-05-23 13:59               ` Florian Weimer
2019-05-23 14:22                 ` Carlos O'Donell
2019-05-23 19:48                   ` DJ Delorie
2019-05-24  4:05                     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKCAbMgNLB_AZ7H3CUsDOHhSnbst-kCjOsZvjEvJikk6-6x8jA@mail.gmail.com \
    --to=zackw@panix.com \
    --cc=dj@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).