From: Carlos O'Donell <carlos@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: fweimer@redhat.com, libc-alpha@sourceware.org
Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
Date: Fri, 24 May 2019 00:05:10 -0400 [thread overview]
Message-ID: <f4ecec69-5ef0-95e8-3539-aa74034a8c3c@redhat.com> (raw)
In-Reply-To: <xnzhndgdeq.fsf@greed.delorie.com>
On 5/23/19 2:48 PM, DJ Delorie wrote:
>
> "Carlos O'Donell" <carlos@redhat.com> writes:
>> I would suggest that test-in-container's initial environment
>> should be as clean as possible, free of any host environment
>> variables.
>
> I don't feel particularly strongly about this as long as my concerns are
> heard, although if we want a clean environment, we're back to filtering
> inside test-container.c itself, since "just don't set it" won't stop the
> user environment from leaking into the container.
Correct. I believe we even discussed this during the initial design, and
rejected it as a non-goal for the first implementation.
I'm OK with filtering directly in test-container.c to leave a clean
environment for the program under test. Somebody needs to implement
that though. Are you volunteering for that Florian? :-)
--
Cheers,
Carlos.
prev parent reply other threads:[~2019-05-24 4:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 17:40 [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH Florian Weimer
2019-05-20 18:19 ` DJ Delorie
2019-05-20 18:23 ` Florian Weimer
2019-05-20 19:26 ` DJ Delorie
2019-05-20 19:38 ` Florian Weimer
2019-05-21 12:49 ` DJ Delorie
2019-05-21 13:06 ` Florian Weimer
2019-05-21 13:24 ` DJ Delorie
2019-05-21 14:04 ` Zack Weinberg
2019-05-23 13:59 ` Florian Weimer
2019-05-23 14:22 ` Carlos O'Donell
2019-05-23 19:48 ` DJ Delorie
2019-05-24 4:05 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ecec69-5ef0-95e8-3539-aa74034a8c3c@redhat.com \
--to=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).