unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
Date: Mon, 20 May 2019 21:38:20 +0200	[thread overview]
Message-ID: <87blzwhq6r.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <xnwoilhqq8.fsf@greed.delorie.com> (DJ Delorie's message of "Mon, 20 May 2019 15:26:39 -0400")

* DJ Delorie:

> Florian Weimer <fweimer@redhat.com> writes:
>> Still there is a separate Rules recipe.
>
> Sure, I'm just saying I thought about this problem when I initially
> wrote it, so we don't have to worry about if test-container itself uses
> a variable.  The goal back then was "test-container should be itself run
> like any other test case".  That means same env vars.
>
> So IMHO the right fix is to filter out those variables inside
> test-container.c where the child's environment is set up.

Should we perhaps start with an environment that contains just PATH, and
add all the *-ENV variables (but not LOCPATH and GCONV_PATH)?

Thanks,
Florian

  reply	other threads:[~2019-05-20 19:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 17:40 [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH Florian Weimer
2019-05-20 18:19 ` DJ Delorie
2019-05-20 18:23   ` Florian Weimer
2019-05-20 19:26     ` DJ Delorie
2019-05-20 19:38       ` Florian Weimer [this message]
2019-05-21 12:49         ` DJ Delorie
2019-05-21 13:06           ` Florian Weimer
2019-05-21 13:24             ` DJ Delorie
2019-05-21 14:04               ` Zack Weinberg
2019-05-23 13:59               ` Florian Weimer
2019-05-23 14:22                 ` Carlos O'Donell
2019-05-23 19:48                   ` DJ Delorie
2019-05-24  4:05                     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blzwhq6r.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).