From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-102159-e=80x24.org@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id A13AC1F462
	for <e@80x24.org>; Tue, 21 May 2019 14:04:32 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:cc:content-type; q=dns; s=default; b=qnrQ
	jmMzvvtaJZ+X8M+tvyPZp2ote0IbjS/Vu2DkPMrRFyiU6rjmJ4/7C2vehp3wgmVm
	RrNys6vBYkc6g+Tg98Wd9I83HpI6mV+7USltmSqLo7lwhliK7QxzfiPfR0YfZUJR
	9B3adM2JO/PvKKY4BETZCeOL4STuNtIEXAqYMd0=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:cc:content-type; s=default; bh=PgAMZ7N05F
	yReM08D4rojj5IhV4=; b=p9vIV4bfNpNsV3CHqpuIhSfkr+KXvOxaZIgS2zbb48
	EAbHXBjL+b0eMv8B6Ft+YdT86wMW3weUhtBbKjLqpoq3CppnqMYs06xi35J6Gp4Q
	LxW3BAfDP1VhXbswqEyRn6gnB4Y+MxJMt5ECTJtKwT6svy4tIQsAOCNKkEmruHwR
	U=
Received: (qmail 50743 invoked by alias); 21 May 2019 14:04:30 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-e=80x24.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 50728 invoked by uid 89); 21 May 2019 14:04:29 -0000
Authentication-Results: sourceware.org; auth=none
X-HELO: mailbackend.panix.com
MIME-Version: 1.0
References: <87lfz09ctu.fsf@oldenburg2.str.redhat.com> <xno93whrej.fsf@greed.delorie.com>
In-Reply-To: <xno93whrej.fsf@greed.delorie.com>
From: Zack Weinberg <zackw@panix.com>
Date: Tue, 21 May 2019 10:04:15 -0400
Message-ID: <CAKCAbMgNLB_AZ7H3CUsDOHhSnbst-kCjOsZvjEvJikk6-6x8jA@mail.gmail.com>
Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
To: DJ Delorie <dj@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>, GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, May 21, 2019 at 9:24 AM DJ Delorie <dj@redhat.com> wrote:
>
> Florian Weimer <fweimer@redhat.com> writes:
> > Sorry, I don't understand.  Why would the user want to run distcc *in
> > the container*?
>
> That was just an example of an environment variable that affects the
> build.  I don't know what environment variables affect the test cases.
> Timeout-related?  Without a review of *every* test that might be run in
> a container, we won't know what environment variables are valid for the
> user to specify.

Maybe we should filter the environment, but have a mechanisme for
explicitly setting environment variables within the container?  For
instance, setting CONTAINER_ENVNAME=value could translate to
ENVNAME=value within the container.

zw