* glibc 2.34
@ 2021-08-02 8:44 Paul Zimmermann
2021-08-02 11:16 ` Szabolcs Nagy via Libc-alpha
0 siblings, 1 reply; 5+ messages in thread
From: Paul Zimmermann @ 2021-08-02 8:44 UTC (permalink / raw)
To: libc-alpha
Hi,
I just compiled GNU libc 2.34 on my workstation (Intel Core i5 under
Debian GNU/Linux 11 bullseye with gcc 10.2.1) and got 3 errors with
make check:
Summary of test results:
3 FAIL
4439 PASS
20 UNSUPPORTED
16 XFAIL
2 XPASS
FAIL: io/tst-closefrom
FAIL: misc/tst-close_range
FAIL: posix/tst-spawn5
$ cat io/tst-closefrom.out
tst-closefrom.c:38: numeric comparison failure
left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 93 (0x5d); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 96 (0x60); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 94 (0x5e); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 97 (0x61); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 95 (0x5f); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 98 (0x62); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 96 (0x60); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 99 (0x63); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 97 (0x61); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 100 (0x64); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 98 (0x62); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 101 (0x65); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 99 (0x63); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 102 (0x66); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 100 (0x64); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 103 (0x67); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 101 (0x65); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 104 (0x68); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 102 (0x66); from: lowfd + i
tst-closefrom.c:38: numeric comparison failure
left: 105 (0x69); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 103 (0x67); from: lowfd + i
error: Differences found in descriptor set
Reference descriptor set:
0: target="pipe:[59077636]" major=0 minor=12 ino=59077636
1: target="/localdisk/zimmerma/glibc-2.34/build/io/tst-closefrom.out" major=8 minor=2 ino=1685502
2: target="/dev/pts/4" major=0 minor=22 ino=7
93: target="/users/zimmerma/.local/share/gvfs-metadata/.nfs0000000000431af300024133" major=0 minor=42 ino=4397811
94: target="/run/user/471/gvfs-metadata/.open1uGfqq (deleted)" major=0 minor=44 ino=61181
Current descriptor set:
0: target="pipe:[59077636]" major=0 minor=12 ino=59077636
1: target="/localdisk/zimmerma/glibc-2.34/build/io/tst-closefrom.out" major=8 minor=2 ino=1685502
2: target="/dev/pts/4" major=0 minor=22 ino=7
Differences:
error: descriptor 93 was closed
error: descriptor 94 was closed
error: 13 test failures
$ cat misc/tst-close_range.out
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 93 (0x5d); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 96 (0x60); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 94 (0x5e); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 97 (0x61); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 95 (0x5f); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 98 (0x62); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 96 (0x60); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 99 (0x63); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 97 (0x61); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 100 (0x64); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 98 (0x62); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 101 (0x65); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 99 (0x63); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 102 (0x66); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 100 (0x64); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 103 (0x67); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 101 (0x65); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 104 (0x68); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 102 (0x66); from: lowfd + i
../sysdeps/unix/sysv/linux/tst-close_range.c:45: numeric comparison failure
left: 105 (0x69); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 103 (0x67); from: lowfd + i
error: Differences found in descriptor set
Reference descriptor set:
0: target="pipe:[59078470]" major=0 minor=12 ino=59078470
1: target="/localdisk/zimmerma/glibc-2.34/build/misc/tst-close_range.out" major=8 minor=2 ino=1685913
2: target="/dev/pts/4" major=0 minor=22 ino=7
93: target="/users/zimmerma/.local/share/gvfs-metadata/.nfs0000000000431af300024133" major=0 minor=42 ino=4397811
94: target="/run/user/471/gvfs-metadata/.open1uGfqq (deleted)" major=0 minor=44 ino=61181
Current descriptor set:
0: target="pipe:[59078470]" major=0 minor=12 ino=59078470
1: target="/localdisk/zimmerma/glibc-2.34/build/misc/tst-close_range.out" major=8 minor=2 ino=1685913
2: target="/dev/pts/4" major=0 minor=22 ino=7
Differences:
error: descriptor 93 was closed
error: descriptor 94 was closed
close_range_cloexec_test: CLOSE_RANGE_CLOEXEC not supported
error: 13 test failures
$ cat posix/tst-spawn5.out
tst-spawn5.c:56: numeric comparison failure
left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 93 (0x5d); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 96 (0x60); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 94 (0x5e); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 97 (0x61); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 95 (0x5f); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 98 (0x62); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 96 (0x60); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 99 (0x63); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 97 (0x61); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 100 (0x64); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 98 (0x62); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 101 (0x65); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 99 (0x63); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 102 (0x66); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 100 (0x64); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 103 (0x67); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 101 (0x65); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 104 (0x68); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 102 (0x66); from: lowfd + i
tst-spawn5.c:56: numeric comparison failure
left: 105 (0x69); from: xopen ("/dev/null", O_RDONLY, 0600)
right: 103 (0x67); from: lowfd + i
error: 11 test failures
Best regards,
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: glibc 2.34
2021-08-02 8:44 glibc 2.34 Paul Zimmermann
@ 2021-08-02 11:16 ` Szabolcs Nagy via Libc-alpha
2021-08-02 11:36 ` Paul Zimmermann
2021-08-02 11:52 ` Florian Weimer via Libc-alpha
0 siblings, 2 replies; 5+ messages in thread
From: Szabolcs Nagy via Libc-alpha @ 2021-08-02 11:16 UTC (permalink / raw)
To: Paul Zimmermann; +Cc: libc-alpha
The 08/02/2021 10:44, Paul Zimmermann wrote:
> I just compiled GNU libc 2.34 on my workstation (Intel Core i5 under
> Debian GNU/Linux 11 bullseye with gcc 10.2.1) and got 3 errors with
> make check:
>
> Summary of test results:
> 3 FAIL
> 4439 PASS
> 20 UNSUPPORTED
> 16 XFAIL
> 2 XPASS
>
> FAIL: io/tst-closefrom
> FAIL: misc/tst-close_range
> FAIL: posix/tst-spawn5
>
> $ cat io/tst-closefrom.out
> tst-closefrom.c:38: numeric comparison failure
> left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
> right: 93 (0x5d); from: lowfd + i
i see similar failure when the shell where i run
the tests has inherited fds open (e.g. in this
case fd 93 and 94)
...
> error: Differences found in descriptor set
> Reference descriptor set:
> 0: target="pipe:[59077636]" major=0 minor=12 ino=59077636
> 1: target="/localdisk/zimmerma/glibc-2.34/build/io/tst-closefrom.out" major=8 minor=2 ino=1685502
> 2: target="/dev/pts/4" major=0 minor=22 ino=7
> 93: target="/users/zimmerma/.local/share/gvfs-metadata/.nfs0000000000431af300024133" major=0 minor=42 ino=4397811
> 94: target="/run/user/471/gvfs-metadata/.open1uGfqq (deleted)" major=0 minor=44 ino=61181
> Current descriptor set:
> 0: target="pipe:[59077636]" major=0 minor=12 ino=59077636
> 1: target="/localdisk/zimmerma/glibc-2.34/build/io/tst-closefrom.out" major=8 minor=2 ino=1685502
> 2: target="/dev/pts/4" major=0 minor=22 ino=7
> Differences:
> error: descriptor 93 was closed
> error: descriptor 94 was closed
> error: 13 test failures
i think the test should work even if fds are inherited.
(e.g. the test should close them before doing the check)
i suspect rerunning the test with
./testrun.sh io/tst-closefrom 93>&- 94>&-
would pass for you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: glibc 2.34
2021-08-02 11:16 ` Szabolcs Nagy via Libc-alpha
@ 2021-08-02 11:36 ` Paul Zimmermann
2021-08-02 11:52 ` Florian Weimer via Libc-alpha
1 sibling, 0 replies; 5+ messages in thread
From: Paul Zimmermann @ 2021-08-02 11:36 UTC (permalink / raw)
To: Szabolcs Nagy; +Cc: libc-alpha
Dear Szabolcs,
> i suspect rerunning the test with
>
> ./testrun.sh io/tst-closefrom 93>&- 94>&-
>
> would pass for you.
indeed:
zimmerma@tomate:/localdisk/zimmerma/glibc-2.34/build$ ./testrun.sh io/tst-closefrom 93>&- 94>&-
zimmerma@tomate:/localdisk/zimmerma/glibc-2.34/build$ echo $?
0
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: glibc 2.34
2021-08-02 11:16 ` Szabolcs Nagy via Libc-alpha
2021-08-02 11:36 ` Paul Zimmermann
@ 2021-08-02 11:52 ` Florian Weimer via Libc-alpha
2021-08-04 13:41 ` Adhemerval Zanella via Libc-alpha
1 sibling, 1 reply; 5+ messages in thread
From: Florian Weimer via Libc-alpha @ 2021-08-02 11:52 UTC (permalink / raw)
To: Szabolcs Nagy via Libc-alpha; +Cc: Szabolcs Nagy
* Szabolcs Nagy via Libc-alpha:
> The 08/02/2021 10:44, Paul Zimmermann wrote:
>> I just compiled GNU libc 2.34 on my workstation (Intel Core i5 under
>> Debian GNU/Linux 11 bullseye with gcc 10.2.1) and got 3 errors with
>> make check:
>>
>> Summary of test results:
>> 3 FAIL
>> 4439 PASS
>> 20 UNSUPPORTED
>> 16 XFAIL
>> 2 XPASS
>>
>> FAIL: io/tst-closefrom
>> FAIL: misc/tst-close_range
>> FAIL: posix/tst-spawn5
>>
>> $ cat io/tst-closefrom.out
>> tst-closefrom.c:38: numeric comparison failure
>> left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
>> right: 93 (0x5d); from: lowfd + i
>
> i see similar failure when the shell where i run
> the tests has inherited fds open (e.g. in this
> case fd 93 and 94)
Right, we saw that internally as well. I think we need a support/
utility that returns the maximum open file descriptor, plus 1, and
raises RLIMIT_NOFILE if necessary.
Thanks,
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: glibc 2.34
2021-08-02 11:52 ` Florian Weimer via Libc-alpha
@ 2021-08-04 13:41 ` Adhemerval Zanella via Libc-alpha
0 siblings, 0 replies; 5+ messages in thread
From: Adhemerval Zanella via Libc-alpha @ 2021-08-04 13:41 UTC (permalink / raw)
To: libc-alpha
On 02/08/2021 08:52, Florian Weimer via Libc-alpha wrote:
> * Szabolcs Nagy via Libc-alpha:
>
>> The 08/02/2021 10:44, Paul Zimmermann wrote:
>>> I just compiled GNU libc 2.34 on my workstation (Intel Core i5 under
>>> Debian GNU/Linux 11 bullseye with gcc 10.2.1) and got 3 errors with
>>> make check:
>>>
>>> Summary of test results:
>>> 3 FAIL
>>> 4439 PASS
>>> 20 UNSUPPORTED
>>> 16 XFAIL
>>> 2 XPASS
>>>
>>> FAIL: io/tst-closefrom
>>> FAIL: misc/tst-close_range
>>> FAIL: posix/tst-spawn5
>>>
>>> $ cat io/tst-closefrom.out
>>> tst-closefrom.c:38: numeric comparison failure
>>> left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
>>> right: 93 (0x5d); from: lowfd + i
>>
>> i see similar failure when the shell where i run
>> the tests has inherited fds open (e.g. in this
>> case fd 93 and 94)
>
> Right, we saw that internally as well. I think we need a support/
> utility that returns the maximum open file descriptor, plus 1, and
> raises RLIMIT_NOFILE if necessary.
I will take care of this.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-04 13:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 8:44 glibc 2.34 Paul Zimmermann
2021-08-02 11:16 ` Szabolcs Nagy via Libc-alpha
2021-08-02 11:36 ` Paul Zimmermann
2021-08-02 11:52 ` Florian Weimer via Libc-alpha
2021-08-04 13:41 ` Adhemerval Zanella via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).