From: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
To: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Cc: libc-alpha@sourceware.org
Subject: Re: glibc 2.34
Date: Mon, 2 Aug 2021 12:16:46 +0100 [thread overview]
Message-ID: <20210802111645.GG14854@arm.com> (raw)
In-Reply-To: <mwh7g85j7t.fsf@tomate.loria.fr>
The 08/02/2021 10:44, Paul Zimmermann wrote:
> I just compiled GNU libc 2.34 on my workstation (Intel Core i5 under
> Debian GNU/Linux 11 bullseye with gcc 10.2.1) and got 3 errors with
> make check:
>
> Summary of test results:
> 3 FAIL
> 4439 PASS
> 20 UNSUPPORTED
> 16 XFAIL
> 2 XPASS
>
> FAIL: io/tst-closefrom
> FAIL: misc/tst-close_range
> FAIL: posix/tst-spawn5
>
> $ cat io/tst-closefrom.out
> tst-closefrom.c:38: numeric comparison failure
> left: 95 (0x5f); from: xopen ("/dev/null", O_RDONLY, 0600)
> right: 93 (0x5d); from: lowfd + i
i see similar failure when the shell where i run
the tests has inherited fds open (e.g. in this
case fd 93 and 94)
...
> error: Differences found in descriptor set
> Reference descriptor set:
> 0: target="pipe:[59077636]" major=0 minor=12 ino=59077636
> 1: target="/localdisk/zimmerma/glibc-2.34/build/io/tst-closefrom.out" major=8 minor=2 ino=1685502
> 2: target="/dev/pts/4" major=0 minor=22 ino=7
> 93: target="/users/zimmerma/.local/share/gvfs-metadata/.nfs0000000000431af300024133" major=0 minor=42 ino=4397811
> 94: target="/run/user/471/gvfs-metadata/.open1uGfqq (deleted)" major=0 minor=44 ino=61181
> Current descriptor set:
> 0: target="pipe:[59077636]" major=0 minor=12 ino=59077636
> 1: target="/localdisk/zimmerma/glibc-2.34/build/io/tst-closefrom.out" major=8 minor=2 ino=1685502
> 2: target="/dev/pts/4" major=0 minor=22 ino=7
> Differences:
> error: descriptor 93 was closed
> error: descriptor 94 was closed
> error: 13 test failures
i think the test should work even if fds are inherited.
(e.g. the test should close them before doing the check)
i suspect rerunning the test with
./testrun.sh io/tst-closefrom 93>&- 94>&-
would pass for you.
next prev parent reply other threads:[~2021-08-02 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 8:44 glibc 2.34 Paul Zimmermann
2021-08-02 11:16 ` Szabolcs Nagy via Libc-alpha [this message]
2021-08-02 11:36 ` Paul Zimmermann
2021-08-02 11:52 ` Florian Weimer via Libc-alpha
2021-08-04 13:41 ` Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802111645.GG14854@arm.com \
--to=libc-alpha@sourceware.org \
--cc=Paul.Zimmermann@inria.fr \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).