* misc/check-installed-headers-c failing due to upstream kernel change
@ 2019-01-21 22:56 Vineet Gupta
2019-01-23 15:57 ` Ben Hutchings
0 siblings, 1 reply; 5+ messages in thread
From: Vineet Gupta @ 2019-01-21 22:56 UTC (permalink / raw)
To: libc-alpha
Hi,
It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
FAIL: misc/check-installed-headers-c
| :: sys/sysctl.h
| ::::
| *** Obsolete types detected:
| ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
| KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
it, but wanted to bring it to notice anyways.
Thx,
-Vineet
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: misc/check-installed-headers-c failing due to upstream kernel change
2019-01-21 22:56 misc/check-installed-headers-c failing due to upstream kernel change Vineet Gupta
@ 2019-01-23 15:57 ` Ben Hutchings
2019-01-23 16:51 ` Carlos O'Donell
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2019-01-23 15:57 UTC (permalink / raw)
To: Vineet Gupta, libc-alpha; +Cc: Feng Tang, Steven Rostedt, Andrew Morton
On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
> Hi,
>
> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
>
> FAIL: misc/check-installed-headers-c
>
> > :: sys/sysctl.h
> > ::::
> > *** Obsolete types detected:
> > ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
> > KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>
> It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
> it, but wanted to bring it to notice anyways.
This additions looks like a mistake, anyway - Linux's binary sysctl
interface is only there for ancient compatibility and no new sysctls
should be added to this enumeration.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: misc/check-installed-headers-c failing due to upstream kernel change
2019-01-23 15:57 ` Ben Hutchings
@ 2019-01-23 16:51 ` Carlos O'Donell
2019-01-23 17:13 ` Vineet Gupta
0 siblings, 1 reply; 5+ messages in thread
From: Carlos O'Donell @ 2019-01-23 16:51 UTC (permalink / raw)
To: Ben Hutchings, Vineet Gupta, libc-alpha
Cc: Feng Tang, Steven Rostedt, Andrew Morton
On 1/23/19 10:57 AM, Ben Hutchings wrote:
> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
>> Hi,
>>
>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
>> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
>>
>> FAIL: misc/check-installed-headers-c
>>
>>> :: sys/sysctl.h
>>> ::::
>>> *** Obsolete types detected:
>>> ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
>>> KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>>
>> It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
>> it, but wanted to bring it to notice anyways.
>
> This additions looks like a mistake, anyway - Linux's binary sysctl
> interface is only there for ancient compatibility and no new sysctls
> should be added to this enumeration.
Just to be clear, this glibc test failure is a false positive [1], and
we're working to correct this [2]. However, if this is also not needed on
the kernel side, then that's also OK with us :-)
--
Cheers,
Carlos.
[1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00413.html
[2] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00513.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: misc/check-installed-headers-c failing due to upstream kernel change
2019-01-23 16:51 ` Carlos O'Donell
@ 2019-01-23 17:13 ` Vineet Gupta
2019-01-23 17:24 ` Carlos O'Donell
0 siblings, 1 reply; 5+ messages in thread
From: Vineet Gupta @ 2019-01-23 17:13 UTC (permalink / raw)
To: Carlos O'Donell, Ben Hutchings, libc-alpha
Cc: arcml, Feng Tang, Steven Rostedt, Andrew Morton
On 1/23/19 8:51 AM, Carlos O'Donell wrote:
> On 1/23/19 10:57 AM, Ben Hutchings wrote:
>> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
>>> Hi,
>>>
>>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
>>> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
>>>
>>> FAIL: misc/check-installed-headers-c
>>>
>>>> :: sys/sysctl.h
>>>> ::::
>>>> *** Obsolete types detected:
>>>> ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
>>>> KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>>>
>>> It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
>>> it, but wanted to bring it to notice anyways.
>>
>> This additions looks like a mistake, anyway - Linux's binary sysctl
>> interface is only there for ancient compatibility and no new sysctls
>> should be added to this enumeration.
>
> Just to be clear, this glibc test failure is a false positive [1], and
> we're working to correct this [2]. However, if this is also not needed on
> the kernel side, then that's also OK with us :-)
>
[1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00413.html
[2] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00513.html
Great, I didn't skim thru the mailing list before posting this. So this is already
known and being worked on !
Does it make sense to add the minimal fix for 2.29 ? It is likely in near future,
people using the released glibc with newer kernel will run into this, unless
kernel folks zap this quickly, within the current release.
-Vineet
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: misc/check-installed-headers-c failing due to upstream kernel change
2019-01-23 17:13 ` Vineet Gupta
@ 2019-01-23 17:24 ` Carlos O'Donell
0 siblings, 0 replies; 5+ messages in thread
From: Carlos O'Donell @ 2019-01-23 17:24 UTC (permalink / raw)
To: Vineet Gupta, Ben Hutchings, libc-alpha
Cc: arcml, Feng Tang, Steven Rostedt, Andrew Morton
On 1/23/19 12:13 PM, Vineet Gupta wrote:
> On 1/23/19 8:51 AM, Carlos O'Donell wrote:
>> On 1/23/19 10:57 AM, Ben Hutchings wrote:
>>> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
>>>> Hi,
>>>>
>>>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
>>>> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
>>>>
>>>> FAIL: misc/check-installed-headers-c
>>>>
>>>>> :: sys/sysctl.h
>>>>> ::::
>>>>> *** Obsolete types detected:
>>>>> ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
>>>>> KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>>>>
>>>> It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
>>>> it, but wanted to bring it to notice anyways.
>>>
>>> This additions looks like a mistake, anyway - Linux's binary sysctl
>>> interface is only there for ancient compatibility and no new sysctls
>>> should be added to this enumeration.
>>
>> Just to be clear, this glibc test failure is a false positive [1], and
>> we're working to correct this [2]. However, if this is also not needed on
>> the kernel side, then that's also OK with us :-)
>>
>
> [1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00413.html
> [2] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00513.html
>
> Great, I didn't skim thru the mailing list before posting this. So this is already
> known and being worked on !
>
> Does it make sense to add the minimal fix for 2.29 ? It is likely in near future,
> people using the released glibc with newer kernel will run into this, unless
> kernel folks zap this quickly, within the current release.
I don't think there is any rush. Review [2] and give Zack any feedback
on correctness? We commit to master, and backport to the release branch
for 2.29 when ready. Developers should be using the release branches.
Distributions already use the release branches to get continued security
fixes and bug fixes.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-23 17:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 22:56 misc/check-installed-headers-c failing due to upstream kernel change Vineet Gupta
2019-01-23 15:57 ` Ben Hutchings
2019-01-23 16:51 ` Carlos O'Donell
2019-01-23 17:13 ` Vineet Gupta
2019-01-23 17:24 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).