From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: Carlos O'Donell <carlos@redhat.com>,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
<libc-alpha@sourceware.org>
Cc: arcml <linux-snps-arc@lists.infradead.org>,
Feng Tang <feng.tang@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: misc/check-installed-headers-c failing due to upstream kernel change
Date: Wed, 23 Jan 2019 09:13:46 -0800 [thread overview]
Message-ID: <a8c5c359-c515-ec77-7498-4a86046bc0e1@synopsys.com> (raw)
In-Reply-To: <26167c76-7d83-40e9-49d3-1c38b6ae3f8a@redhat.com>
On 1/23/19 8:51 AM, Carlos O'Donell wrote:
> On 1/23/19 10:57 AM, Ben Hutchings wrote:
>> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
>>> Hi,
>>>
>>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
>>> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
>>>
>>> FAIL: misc/check-installed-headers-c
>>>
>>>> :: sys/sysctl.h
>>>> ::::
>>>> *** Obsolete types detected:
>>>> ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
>>>> KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>>>
>>> It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
>>> it, but wanted to bring it to notice anyways.
>>
>> This additions looks like a mistake, anyway - Linux's binary sysctl
>> interface is only there for ancient compatibility and no new sysctls
>> should be added to this enumeration.
>
> Just to be clear, this glibc test failure is a false positive [1], and
> we're working to correct this [2]. However, if this is also not needed on
> the kernel side, then that's also OK with us :-)
>
[1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00413.html
[2] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00513.html
Great, I didn't skim thru the mailing list before posting this. So this is already
known and being worked on !
Does it make sense to add the minimal fix for 2.29 ? It is likely in near future,
people using the released glibc with newer kernel will run into this, unless
kernel folks zap this quickly, within the current release.
-Vineet
next prev parent reply other threads:[~2019-01-23 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 22:56 misc/check-installed-headers-c failing due to upstream kernel change Vineet Gupta
2019-01-23 15:57 ` Ben Hutchings
2019-01-23 16:51 ` Carlos O'Donell
2019-01-23 17:13 ` Vineet Gupta [this message]
2019-01-23 17:24 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c5c359-c515-ec77-7498-4a86046bc0e1@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=carlos@redhat.com \
--cc=feng.tang@intel.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).