From: Junio C Hamano <gitster@pobox.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>,
Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs
Date: Sat, 30 Jan 2021 15:48:01 -0800 [thread overview]
Message-ID: <xmqqy2gang0e.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <028152B6-DA5B-40F7-B944-FF4F31C2BC56@gmail.com> (Kyle J. McKay's message of "Sat, 30 Jan 2021 16:02:03 -0700")
"Kyle J. McKay" <mackyle@gmail.com> writes:
> On Jan 30, 2021, at 11:56, Junio C Hamano wrote:
>
>> The said commit came as part of this topic, ...
>>
>> https://lore.kernel.org/git/pull.669.v2.git.1594401593.gitgitgadget@gmail.com/
>>
>> ... so I've added the true author of it on the Cc: list.
>
> Out of curiosity, if Han-Wen Nienhuys is the true author of commit
> 523fa69c36744ae6 why is it that you are both the committer and author
> of that commit in the commit's header?
See how the e-mail message was formatted in that thread. I just ran
"am" on it (which makes me responsible for committing), and the
authorship comes from the "From:" that was in the body. I suspect
he may have based the patch on some of the "how about doing it like
so" suggestions I made during an earlier discussion and wanted to
give me credit for the input, but I do not remember the context the
patch was originally written in X-<.
next prev parent reply other threads:[~2021-01-31 0:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 10:19 [PATCH 0/2] Eliminate extraneous ref log entries Kyle J. McKay
2021-01-30 10:19 ` [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs Kyle J. McKay
2021-01-30 18:56 ` Junio C Hamano
2021-01-30 23:02 ` Kyle J. McKay
2021-01-30 23:48 ` Junio C Hamano [this message]
2021-02-01 11:09 ` Han-Wen Nienhuys
2021-01-30 23:26 ` Kyle J. McKay
2021-01-31 0:11 ` Junio C Hamano
2021-01-30 10:19 ` [PATCH 2/2] refs.c: avoid creating extra unwanted reflog entries Kyle J. McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2gang0e.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).