git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>,
	Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs
Date: Sat, 30 Jan 2021 16:11:19 -0800	[thread overview]
Message-ID: <xmqqo8h6nexk.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <81AEEED6-26EC-4F32-AA65-B028435D812D@gmail.com> (Kyle J. McKay's message of "Sat, 30 Jan 2021 16:26:55 -0700")

"Kyle J. McKay" <mackyle@gmail.com> writes:

> I'm having a bit of trouble parsing that into expectations.  A little
> help please.
> Are you suggesting that (1) just be omitted?  Or that it be modified
> so that it's an "expect success" patch?

Neither.

The result of applying the current 1/2 and 2/2 on top of, say
'master', would be the shape of the tree you would want to be in.

Our preference is just to have it as a single patch, not as "first
expect failure and then flip it to expect success while modifying
the code".  That approach makes the second step harder to review
than necessary, because the "git show" output and "format-patch"
output from the step would show only very little about the test
that changes behaviour.

Even with a single patch, if somebody wants a demonstration of what
used to be broken without the code modification, it is easy to apply
only the test part of the single patch without using the code change
to see how it breaks, so "I want to demonstrate the breakage" is not
a reason to have it as a separate step.

Thanks.

  reply	other threads:[~2021-01-31  0:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30 10:19 [PATCH 0/2] Eliminate extraneous ref log entries Kyle J. McKay
2021-01-30 10:19 ` [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs Kyle J. McKay
2021-01-30 18:56   ` Junio C Hamano
2021-01-30 23:02     ` Kyle J. McKay
2021-01-30 23:48       ` Junio C Hamano
2021-02-01 11:09         ` Han-Wen Nienhuys
2021-01-30 23:26     ` Kyle J. McKay
2021-01-31  0:11       ` Junio C Hamano [this message]
2021-01-30 10:19 ` [PATCH 2/2] refs.c: avoid creating extra unwanted reflog entries Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo8h6nexk.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hanwen@google.com \
    --cc=mackyle@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).