From: "Kyle J. McKay" <mackyle@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>
Subject: [PATCH 0/2] Eliminate extraneous ref log entries
Date: Sat, 30 Jan 2021 03:19:07 -0700 [thread overview]
Message-ID: <7c7e8679f2da7e1475606d698b2da8c@72481c9465c8b2c4aaff8b77ab5e23c> (raw)
Since Git version v2.29.0, the `git symbolic-ref` command has started
adding extraneous entries to the ref log of the symbolic ref it's
updating.
This change was inadvertently introduced in commit 523fa69c36744ae6
("reflog: cleanse messages in the refs.c layer", 2020-07-10, v2.29.0).
A bug report [1] was made about a failing test in the TopGit test
suite. Further investigations into the cause led to this patch set.
1/2 - adds new tests to monitor this behavior
2/2 - corrects the problem
The tests added in 1/2 are marked `test_expect_failure` and then
changed to `test_expect_success` in 2/2.
-Kyle
[1]: <https://github.com/mackyle/topgit/issues/17>
Kyle J. McKay (2):
t/t1417: test symbolic-ref effects on ref logs
refs.c: avoid creating extra unwanted reflog entries
refs.c | 16 +++----
t/t1417-reflog-symref.sh | 91 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 100 insertions(+), 7 deletions(-)
create mode 100755 t/t1417-reflog-symref.sh
--
next reply other threads:[~2021-01-30 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 10:19 Kyle J. McKay [this message]
2021-01-30 10:19 ` [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs Kyle J. McKay
2021-01-30 18:56 ` Junio C Hamano
2021-01-30 23:02 ` Kyle J. McKay
2021-01-30 23:48 ` Junio C Hamano
2021-02-01 11:09 ` Han-Wen Nienhuys
2021-01-30 23:26 ` Kyle J. McKay
2021-01-31 0:11 ` Junio C Hamano
2021-01-30 10:19 ` [PATCH 2/2] refs.c: avoid creating extra unwanted reflog entries Kyle J. McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c7e8679f2da7e1475606d698b2da8c@72481c9465c8b2c4aaff8b77ab5e23c \
--to=mackyle@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).