From: Han-Wen Nienhuys <hanwen@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Kyle J. McKay" <mackyle@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs
Date: Mon, 1 Feb 2021 12:09:08 +0100 [thread overview]
Message-ID: <CAFQ2z_Mb86W7PnRfO2wcRqqS3UBOb+TpvOXQ5-UJr0aH6OnJFg@mail.gmail.com> (raw)
In-Reply-To: <xmqqy2gang0e.fsf@gitster.c.googlers.com>
On Sun, Jan 31, 2021 at 12:48 AM Junio C Hamano <gitster@pobox.com> wrote:
> > On Jan 30, 2021, at 11:56, Junio C Hamano wrote:
> >
> >> The said commit came as part of this topic, ...
> >>
> >> https://lore.kernel.org/git/pull.669.v2.git.1594401593.gitgitgadget@gmail.com/
> >>
> >> ... so I've added the true author of it on the Cc: list.
> >
> > Out of curiosity, if Han-Wen Nienhuys is the true author of commit
> > 523fa69c36744ae6 why is it that you are both the committer and author
> > of that commit in the commit's header?
>
> See how the e-mail message was formatted in that thread. I just ran
> "am" on it (which makes me responsible for committing), and the
> authorship comes from the "From:" that was in the body. I suspect
> he may have based the patch on some of the "how about doing it like
> so" suggestions I made during an earlier discussion and wanted to
> give me credit for the input, but I do not remember the context the
> patch was originally written in X-<.
The classic reflog format doesn't allow '\n' in messages, but
different parts of the code did try to write '\n'. This patch was
supposed to sanitize the messages in a central location, so alternate
ref backends do not trigger spurious differences in how reflogs are
represented.
Your patch says
> has changed in an unexpected way.
Can you make the expectations and current behavior explicit?
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
next prev parent reply other threads:[~2021-02-01 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 10:19 [PATCH 0/2] Eliminate extraneous ref log entries Kyle J. McKay
2021-01-30 10:19 ` [PATCH 1/2] t/t1417: test symbolic-ref effects on ref logs Kyle J. McKay
2021-01-30 18:56 ` Junio C Hamano
2021-01-30 23:02 ` Kyle J. McKay
2021-01-30 23:48 ` Junio C Hamano
2021-02-01 11:09 ` Han-Wen Nienhuys [this message]
2021-01-30 23:26 ` Kyle J. McKay
2021-01-31 0:11 ` Junio C Hamano
2021-01-30 10:19 ` [PATCH 2/2] refs.c: avoid creating extra unwanted reflog entries Kyle J. McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFQ2z_Mb86W7PnRfO2wcRqqS3UBOb+TpvOXQ5-UJr0aH6OnJFg@mail.gmail.com \
--to=hanwen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).