From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 10/22] http.c: mark strings for translation
Date: Mon, 29 Feb 2016 10:31:44 -0800 [thread overview]
Message-ID: <xmqqwppnbc6n.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1456555333-5853-11-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Sat, 27 Feb 2016 13:42:01 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
All (or at least most of) these look old ones. I'm inclined to say
we should do the whole thing post 2.8.0 release for this file.
> http.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/http.c b/http.c
> index 1d5e3bb..d56cb52 100644
> --- a/http.c
> +++ b/http.c
> @@ -404,7 +404,7 @@ static void init_curl_proxy_auth(CURL *result)
> }
> }
> if (i == ARRAY_SIZE(proxy_authmethods)) {
> - warning("unsupported proxy authentication method %s: using anyauth",
> + warning(_("unsupported proxy authentication method %s: using anyauth"),
> http_proxy_authmethod);
> curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
> }
> @@ -445,7 +445,7 @@ static int sockopt_callback(void *client, curl_socket_t fd, curlsocktype type)
>
> rc = setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, (void *)&ka, len);
> if (rc < 0)
> - warning("unable to set SO_KEEPALIVE on socket %s",
> + warning(_("unable to set SO_KEEPALIVE on socket %s"),
> strerror(errno));
>
> return 0; /* CURL_SOCKOPT_OK only exists since curl 7.21.5 */
> @@ -469,7 +469,7 @@ static CURL *get_curl_handle(void)
> long allowed_protocols = 0;
>
> if (!result)
> - die("curl_easy_init failed");
> + die(_("curl_easy_init failed"));
>
> if (!curl_ssl_verify) {
> curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 0);
> @@ -503,7 +503,7 @@ static CURL *get_curl_handle(void)
> }
> }
> if (i == ARRAY_SIZE(sslversions))
> - warning("unsupported ssl version %s: using default",
> + warning(_("unsupported ssl version %s: using default"),
> ssl_version);
> }
>
> @@ -558,8 +558,8 @@ static CURL *get_curl_handle(void)
> curl_easy_setopt(result, CURLOPT_REDIR_PROTOCOLS, allowed_protocols);
> #else
> if (transport_restrict_protocols())
> - warning("protocol restrictions not applied to curl redirects because\n"
> - "your curl version is too old (>= 7.19.4)");
> + warning(_("protocol restrictions not applied to curl redirects because\n"
> + "your curl version is too old (>= 7.19.4)"));
> #endif
>
> if (getenv("GIT_CURL_VERBOSE"))
> @@ -659,7 +659,7 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
> free(normalized_url);
>
> if (curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK)
> - die("curl_global_init failed");
> + die(_("curl_global_init failed"));
>
> http_proactive_auth = proactive_auth;
>
> @@ -681,7 +681,7 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
>
> curlm = curl_multi_init();
> if (!curlm)
> - die("curl_multi_init failed");
> + die(_("curl_multi_init failed"));
> #endif
>
> if (getenv("GIT_SSL_NO_VERIFY"))
> @@ -1544,7 +1544,7 @@ static int http_get_file(const char *url, const char *filename,
> strbuf_addf(&tmpfile, "%s.temp", filename);
> result = fopen(tmpfile.buf, "a");
> if (!result) {
> - error("Unable to open local file %s", tmpfile.buf);
> + error(_("Unable to open local file %s"), tmpfile.buf);
> ret = HTTP_ERROR;
> goto cleanup;
> }
> @@ -1601,7 +1601,7 @@ static char *fetch_pack_index(unsigned char *sha1, const char *base_url)
> tmp = strbuf_detach(&buf, NULL);
>
> if (http_get_file(url, tmp, NULL) != HTTP_OK) {
> - error("Unable to get pack index %s", url);
> + error(_("Unable to get pack index %s"), url);
> free(tmp);
> tmp = NULL;
> }
> @@ -1778,7 +1778,7 @@ struct http_pack_request *new_http_pack_request(
> sha1_pack_name(target->sha1));
> preq->packfile = fopen(preq->tmpfile, "a");
> if (!preq->packfile) {
> - error("Unable to open local file %s for pack",
> + error(_("Unable to open local file %s for pack"),
> preq->tmpfile);
> goto abort;
> }
> @@ -1866,7 +1866,7 @@ struct http_object_request *new_http_object_request(const char *base_url,
> unlink_or_warn(freq->tmpfile);
>
> if (freq->localfile != -1)
> - error("fd leakage in start: %d", freq->localfile);
> + error(_("fd leakage in start: %d"), freq->localfile);
> freq->localfile = open(freq->tmpfile,
> O_WRONLY | O_CREAT | O_EXCL, 0666);
> /*
> @@ -1885,7 +1885,7 @@ struct http_object_request *new_http_object_request(const char *base_url,
> }
>
> if (freq->localfile < 0) {
> - error("Couldn't create temporary file %s: %s",
> + error(_("Couldn't create temporary file %s: %s"),
> freq->tmpfile, strerror(errno));
> goto abort;
> }
> @@ -1931,7 +1931,7 @@ struct http_object_request *new_http_object_request(const char *base_url,
> prev_posn = 0;
> lseek(freq->localfile, 0, SEEK_SET);
> if (ftruncate(freq->localfile, 0) < 0) {
> - error("Couldn't truncate temporary file %s: %s",
> + error(_("Couldn't truncate temporary file %s: %s"),
> freq->tmpfile, strerror(errno));
> goto abort;
> }
> @@ -1985,7 +1985,7 @@ int finish_http_object_request(struct http_object_request *freq)
> process_http_object_request(freq);
>
> if (freq->http_code == 416) {
> - warning("requested range invalid; we may already have all the data.");
> + warning(_("requested range invalid; we may already have all the data."));
> } else if (freq->curl_result != CURLE_OK) {
> if (stat(freq->tmpfile, &st) == 0)
> if (st.st_size == 0)
next prev parent reply other threads:[~2016-02-29 18:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 6:41 [PATCH 00/22] Mark more strings for translation Nguyễn Thái Ngọc Duy
2016-02-27 6:41 ` [PATCH 01/22] credential-cache--daemon: enable localized messages Nguyễn Thái Ngọc Duy
2016-02-27 6:41 ` [PATCH 02/22] builtin/blame.c: mark strings for translation Nguyễn Thái Ngọc Duy
2016-02-28 18:57 ` Junio C Hamano
2016-02-29 0:33 ` Duy Nguyen
2016-02-29 18:22 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 03/22] builtin/checkout.c: " Nguyễn Thái Ngọc Duy
2016-02-28 19:00 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 04/22] builtin/clone.c: " Nguyễn Thái Ngọc Duy
2016-02-28 19:05 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 05/22] builtin/config.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:25 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 06/22] " Nguyễn Thái Ngọc Duy
2016-02-27 6:41 ` [PATCH 07/22] builtin/update-index.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:27 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 08/22] convert.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:29 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 09/22] credential-cache--daemon.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:30 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 10/22] http.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:31 ` Junio C Hamano [this message]
2016-02-27 6:42 ` [PATCH 11/22] ident.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:34 ` Junio C Hamano
2016-03-01 14:56 ` Jeff King
2016-02-27 6:42 ` [PATCH 12/22] notes.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:36 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 13/22] ref-filter.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:41 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 14/22] refs/files-backend.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:43 ` Junio C Hamano
2016-03-01 10:40 ` Duy Nguyen
2016-02-27 6:42 ` [PATCH 15/22] remote-curl.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:50 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 16/22] run-command.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:52 ` Junio C Hamano
2016-03-01 0:00 ` Stefan Beller
2016-02-27 6:42 ` [PATCH 17/22] sha1_file.c: " Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 18/22] submodule.c: " Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 19/22] trailer.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:55 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 20/22] transport-helper.c: mark strings for translating Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 21/22] transport.c: " Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 22/22] wrapper.c: mark strings for translation Nguyễn Thái Ngọc Duy
2016-02-27 17:34 ` [PATCH 00/22] Mark more " Junio C Hamano
2016-02-27 19:00 ` Junio C Hamano
2016-02-28 0:43 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwppnbc6n.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).