git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS
Date: Mon, 08 Jul 2019 12:23:00 -0700	[thread overview]
Message-ID: <xmqqv9wcxre3.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1f0f4fe6fbf0e7a7eea1f3d49db183c70693a895.1562231679.git.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Thu, 04 Jul 2019 02:14:40 -0700 (PDT)")

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> A `+` is not a valid part of a filename with Windows file systems (it is
> reserved because the `+` operator meant file concatenation back in the
> DOS days).

The title of the cover letter had "windows" in it, so calling '+'
illegal was OK, but this patch does not.

I'd rather not to take this patch, because "generate in the target
with plus appended, make sure it succeeds, and then rename it to the
real target" is quite an established pattern not limited to the
Documentation/ directory of this project, if your tooling has been
supporting it and can continue to do so (which was the impression I
got from the cover letter).  Even the top-level .gitignore file
knows about it, so does the top-level Makefile and it uses the same
pattern.


  reply	other threads:[~2019-07-08 19:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  9:14 [PATCH 0/1] windows: avoid illegal filenames during a build Johannes Schindelin via GitGitGadget
2019-07-04  9:14 ` [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS Johannes Schindelin via GitGitGadget
2019-07-08 19:23   ` Junio C Hamano [this message]
2019-07-09 13:27     ` Johannes Schindelin
2019-07-09 14:43       ` Junio C Hamano
2019-07-10 10:08         ` Johannes Schindelin
2019-07-10 18:26         ` Junio C Hamano
2019-07-10 20:35           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv9wcxre3.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).