git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS
Date: Wed, 10 Jul 2019 22:35:34 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1907102137060.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqef2xu4oz.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Wed, 10 Jul 2019, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
>
> >> In addition, your `+` scheme will break on Windows once it uses `git.exe`
> >> or any other non-MSYS2 helper...
> >
> > I am not sure what you mean here.  Is your git.exe disabled not to
> > be able to do this: "git.exe add hello+kitty.txt"?

It's not that. The `+` is not allowed on Windows in general.

Mind you, I just read up on the details (see e.g.
https://en.wikipedia.org/wiki/Filename#Comparison_of_filename_limitations)
and it looks as if NTFS actually _allows_ this. Even VFAT allows it, but
FAT32 does not.

So I guess I retract my objections, as there are probably smarter ideas
than building Git for Windows on a FAT32 drive.

For aesthetical reasons, I still do not like the convention to append a
`+` when appending `.new` would make things clearer, but this is not a
hill I am prepared to die on.

Ciao,
Dscho

      reply	other threads:[~2019-07-10 20:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  9:14 [PATCH 0/1] windows: avoid illegal filenames during a build Johannes Schindelin via GitGitGadget
2019-07-04  9:14 ` [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS Johannes Schindelin via GitGitGadget
2019-07-08 19:23   ` Junio C Hamano
2019-07-09 13:27     ` Johannes Schindelin
2019-07-09 14:43       ` Junio C Hamano
2019-07-10 10:08         ` Johannes Schindelin
2019-07-10 18:26         ` Junio C Hamano
2019-07-10 20:35           ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1907102137060.46@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).