git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS
Date: Tue, 9 Jul 2019 15:27:11 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1907091524460.5700@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqv9wcxre3.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Mon, 8 Jul 2019, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > A `+` is not a valid part of a filename with Windows file systems (it is
> > reserved because the `+` operator meant file concatenation back in the
> > DOS days).
>
> I'd rather not to take this patch, because "generate in the target
> with plus appended, make sure it succeeds, and then rename it to the
> real target" is quite an established pattern not limited to the
> Documentation/ directory of this project, if your tooling has been
> supporting it and can continue to do so (which was the impression I
> got from the cover letter).  Even the top-level .gitignore file
> knows about it, so does the top-level Makefile and it uses the same
> pattern.

Using `.lock` is actually an even more established pattern. (I used `.new`
because the intention is not to lock files, but I would be prepared to
change the patch to that end.)

In addition, your `+` scheme will break on Windows once it uses `git.exe`
or any other non-MSYS2 helper, so it is not future-proof, no matter how
established you claim it to be.

Ciao,
Dscho

  reply	other threads:[~2019-07-09 13:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  9:14 [PATCH 0/1] windows: avoid illegal filenames during a build Johannes Schindelin via GitGitGadget
2019-07-04  9:14 ` [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS Johannes Schindelin via GitGitGadget
2019-07-08 19:23   ` Junio C Hamano
2019-07-09 13:27     ` Johannes Schindelin [this message]
2019-07-09 14:43       ` Junio C Hamano
2019-07-10 10:08         ` Johannes Schindelin
2019-07-10 18:26         ` Junio C Hamano
2019-07-10 20:35           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1907091524460.5700@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).