Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

[Junio C Hamano <gitster@pobox.com>]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Using `.lock` is actually an even more established pattern. (I used `.new`
> because the intention is not to lock files, but I would be prepared to
> change the patch to that end.)

When I said that the plus convention is established in this project
and not limited to the Documentation subdirectory, what I meant was
that your patch is insufficient if your goal is to depart from the
convention.

The pattern "*+" is known bythe top-level .gitignore file (not just
in Documentation/.gitignore) and that is because the build procedure
outside Documentation/ also follow the convention, e.g. the toplevel
Makefile.  Futzing with only one Makefile is not enough.

I think I saw "generate in .tmp, then move to final" pattern used in
projects by others.  The plus-sign is a lot shorter than anything
else and it is cute, but if some filesystems cannot deal with it,
changing it to something else may be a plausible workaround, as long
as it is done consistently and throughout the codebase.

> In addition, your `+` scheme will break on Windows once it uses `git.exe`
> or any other non-MSYS2 helper...

I am not sure what you mean here.  Is your git.exe disabled not to
be able to do this: "git.exe add hello+kitty.txt"?  I think that is
a more grave problem, and not limited to the Makefile in the
Documentation/ directory.