From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, Lubomir Rintel <lkundrak@v3.sk>,
git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
"Dixit\, Ashutosh" <ashutosh.dixit@intel.com>,
Jiri Slaby <jslaby@suse.cz>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH] Revert "fetch: default to protocol version 2"
Date: Wed, 22 Apr 2020 11:23:25 -0700 [thread overview]
Message-ID: <xmqqtv1bidlu.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200422155047.GB91734@google.com> (Jonathan Nieder's message of "Wed, 22 Apr 2020 08:50:47 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> This reverts commit 684ceae32dae726c6a5c693b257b156926aba8b7.
>
> Users fetching from linux-next and other kernel remotes are reporting
> that the limited ref advertisement causes negotiation to reach
> MAX_IN_VAIN, resulting in too-large fetches.
>
> Reported-by: Lubomir Rintel <lkundrak@v3.sk>
> Reported-by: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
> Reported-by: Jiri Slaby <jslaby@suse.cz>
> Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
With the one-liner fix for resetting the "we haven't heard an Ack"
timer, I am no longer so worried by hurting users by keeping them on
v2 by default, but it will take some time for the fix to trickle
down from the 'master' track to a maintenance release, so I am OK to
apply this patch in the meantime. But let's flip the default back
to v2 after the one-liner fix lands to see if (1) the fix truly
helps and (2) people hit other issues in the difference between v0
and v2.
Thanks.
next prev parent reply other threads:[~2020-04-22 18:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 8:42 Git 2.26 fetches many times more objects than it should, wasting gigabytes Lubomir Rintel
2020-04-22 9:57 ` Jeff King
2020-04-22 10:30 ` Jeff King
2020-04-22 10:40 ` Jeff King
2020-04-22 15:33 ` Junio C Hamano
2020-04-22 19:33 ` Jeff King
2020-04-23 21:37 ` Jonathan Tan
2020-04-23 21:54 ` Junio C Hamano
2020-04-24 5:32 ` Jeff King
2020-04-22 15:40 ` Jonathan Nieder
2020-04-22 19:36 ` Jeff King
2020-04-22 15:50 ` [PATCH] Revert "fetch: default to protocol version 2" Jonathan Nieder
2020-04-22 18:23 ` Junio C Hamano [this message]
2020-04-22 19:40 ` Jeff King
2020-04-22 19:47 ` Jeff King
2020-04-22 16:53 ` Git 2.26 fetches many times more objects than it should, wasting gigabytes Jonathan Nieder
2020-04-22 17:32 ` Junio C Hamano
2020-04-22 19:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtv1bidlu.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=ashutosh.dixit@intel.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=jslaby@suse.cz \
--cc=konstantin@linuxfoundation.org \
--cc=lkundrak@v3.sk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).