From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, Lubomir Rintel <lkundrak@v3.sk>,
git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: Git 2.26 fetches many times more objects than it should, wasting gigabytes
Date: Wed, 22 Apr 2020 10:32:38 -0700 [thread overview]
Message-ID: <xmqq7dy7juix.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200422165358.GB140314@google.com> (Jonathan Nieder's message of "Wed, 22 Apr 2020 09:53:58 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> When process_acks sees an ACK, it passes it on to the negotiator.
> It wants to record that it received an ack to reset in_vain, but
> it forgets to! The function is initialized and read but never
> written to.
Yeah, this smells like the right solution ;-)
s/function/variable/ though.
>
> So I'd expect the following to help:
>
> diff --git i/fetch-pack.c w/fetch-pack.c
> index 1734a573b01..a1d743e1f61 100644
> --- i/fetch-pack.c
> +++ w/fetch-pack.c
> @@ -1287,6 +1287,8 @@ static int process_acks(struct fetch_negotiator *negotiator,
> struct object_id oid;
> if (!get_oid_hex(arg, &oid)) {
> struct commit *commit;
> +
> + received_ack = 1;
> oidset_insert(common, &oid);
> commit = lookup_commit(the_repository, &oid);
> if (negotiator)
next prev parent reply other threads:[~2020-04-22 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 8:42 Git 2.26 fetches many times more objects than it should, wasting gigabytes Lubomir Rintel
2020-04-22 9:57 ` Jeff King
2020-04-22 10:30 ` Jeff King
2020-04-22 10:40 ` Jeff King
2020-04-22 15:33 ` Junio C Hamano
2020-04-22 19:33 ` Jeff King
2020-04-23 21:37 ` Jonathan Tan
2020-04-23 21:54 ` Junio C Hamano
2020-04-24 5:32 ` Jeff King
2020-04-22 15:40 ` Jonathan Nieder
2020-04-22 19:36 ` Jeff King
2020-04-22 15:50 ` [PATCH] Revert "fetch: default to protocol version 2" Jonathan Nieder
2020-04-22 18:23 ` Junio C Hamano
2020-04-22 19:40 ` Jeff King
2020-04-22 19:47 ` Jeff King
2020-04-22 16:53 ` Git 2.26 fetches many times more objects than it should, wasting gigabytes Jonathan Nieder
2020-04-22 17:32 ` Junio C Hamano [this message]
2020-04-22 19:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dy7juix.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=lkundrak@v3.sk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).