From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
"Dixit, Ashutosh" <ashutosh.dixit@intel.com>,
Jiri Slaby <jslaby@suse.cz>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] Revert "fetch: default to protocol version 2"
Date: Wed, 22 Apr 2020 08:50:47 -0700 [thread overview]
Message-ID: <20200422155047.GB91734@google.com> (raw)
In-Reply-To: <20200422095702.GA475060@coredump.intra.peff.net>
This reverts commit 684ceae32dae726c6a5c693b257b156926aba8b7.
Users fetching from linux-next and other kernel remotes are reporting
that the limited ref advertisement causes negotiation to reach
MAX_IN_VAIN, resulting in too-large fetches.
Reported-by: Lubomir Rintel <lkundrak@v3.sk>
Reported-by: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Reported-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Hi again,
Jeff King wrote:
> Thanks for this report. We've been tracking the issue but have had
> trouble reproducing it.
>
> To get you unstuck, the immediate workaround is to drop back to the
> older protocol, like:
>
> git -c protocol.version=0 fetch --all
By the way, I'd recommend the immediate workaround of
git fetch --negotiation-tip=refs/remotes/xo/* xo
instead. But that's a separate subject.
[...]
> There are a few data points we've been wanting to collect:
[...]
> I'm attaching for-each-ref output before and after the xo fetch. That
> should be sufficient to recreate the situation synthetically even once
> these repos have moved on.
Excellent --- I think this is enough for us to have something to use
to investigate, switching users to protocol v0 in the meantime.
Thanks,
Jonathan
Documentation/config/protocol.txt | 2 +-
protocol.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/config/protocol.txt b/Documentation/config/protocol.txt
index 756591d77b0..0b40141613e 100644
--- a/Documentation/config/protocol.txt
+++ b/Documentation/config/protocol.txt
@@ -48,7 +48,7 @@ protocol.version::
If set, clients will attempt to communicate with a server
using the specified protocol version. If the server does
not support it, communication falls back to version 0.
- If unset, the default is `2`.
+ If unset, the default is `0`.
Supported versions:
+
--
diff --git a/protocol.c b/protocol.c
index 803bef5c87e..d390391ebac 100644
--- a/protocol.c
+++ b/protocol.c
@@ -39,7 +39,7 @@ enum protocol_version get_protocol_version_config(void)
return env;
}
- return protocol_v2;
+ return protocol_v0;
}
enum protocol_version determine_protocol_version_server(void)
--
2.26.2.303.gf8c07b1a785
next prev parent reply other threads:[~2020-04-22 15:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 8:42 Git 2.26 fetches many times more objects than it should, wasting gigabytes Lubomir Rintel
2020-04-22 9:57 ` Jeff King
2020-04-22 10:30 ` Jeff King
2020-04-22 10:40 ` Jeff King
2020-04-22 15:33 ` Junio C Hamano
2020-04-22 19:33 ` Jeff King
2020-04-23 21:37 ` Jonathan Tan
2020-04-23 21:54 ` Junio C Hamano
2020-04-24 5:32 ` Jeff King
2020-04-22 15:40 ` Jonathan Nieder
2020-04-22 19:36 ` Jeff King
2020-04-22 15:50 ` Jonathan Nieder [this message]
2020-04-22 18:23 ` [PATCH] Revert "fetch: default to protocol version 2" Junio C Hamano
2020-04-22 19:40 ` Jeff King
2020-04-22 19:47 ` Jeff King
2020-04-22 16:53 ` Git 2.26 fetches many times more objects than it should, wasting gigabytes Jonathan Nieder
2020-04-22 17:32 ` Junio C Hamano
2020-04-22 19:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422155047.GB91734@google.com \
--to=jrnieder@gmail.com \
--cc=ashutosh.dixit@intel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jslaby@suse.cz \
--cc=konstantin@linuxfoundation.org \
--cc=lkundrak@v3.sk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).