From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Shubham Mishra <shivam828787@gmail.com>,
git <git@vger.kernel.org>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 1/2] t0001: remove pipes
Date: Wed, 23 Feb 2022 13:07:12 -0800 [thread overview]
Message-ID: <xmqqsfs9thq7.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD1FVuoe7V3JU+hExsbjWTkNZFCZFV4qc65YLd4ow-Da5w@mail.gmail.com> (Christian Couder's message of "Tue, 22 Feb 2022 21:32:30 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> Only the exit code of the command before the pipe is ignored.
>
> Also it's ok to use pipes if the command before the pipe is not `git`.
> We trust regular commands to just work and we test only `git`.
Both very good points. So ...
>> - find .git/worktrees -print | sort >expected &&
>> + find .git/worktrees -print >tmp && sort tmp >expected &&
>
> Please put the `find` and `sort` commands on 2 different lines when
> they are separated with &&.
We do not want to split this pipeline into two commands.
next prev parent reply other threads:[~2022-02-23 21:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 11:43 [PATCH 0/2] microproject: avoid using pipes in test Shubham Mishra
2022-02-22 11:43 ` [PATCH 1/2] t0001: remove pipes Shubham Mishra
2022-02-22 13:54 ` Derrick Stolee
2022-02-22 18:16 ` Shubham Mishra
2022-02-22 20:32 ` Christian Couder
2022-02-23 21:07 ` Junio C Hamano [this message]
2022-02-24 3:28 ` Christian Couder
2022-02-22 11:43 ` [PATCH 2/2] t0003: " Shubham Mishra
2022-02-22 13:50 ` [PATCH 0/2] microproject: avoid using pipes in test Derrick Stolee
2022-02-22 14:24 ` Ævar Arnfjörð Bjarmason
2022-02-22 19:12 ` Shubham Mishra
2022-02-22 19:39 ` Taylor Blau
2022-02-23 11:53 ` [PATCH v2 0/2] avoid pipes with Git on LHS Shubham Mishra
2022-02-23 11:53 ` [PATCH v2 1/2] t0001: " Shubham Mishra
2022-02-23 17:53 ` Taylor Blau
2022-02-23 18:01 ` Shubham Mishra
2022-02-23 18:02 ` Taylor Blau
2022-02-23 21:10 ` Junio C Hamano
2022-02-24 5:14 ` Shubham Mishra
2022-02-23 11:53 ` [PATCH v2 2/2] t0003: " Shubham Mishra
2022-02-23 17:54 ` Taylor Blau
2022-02-23 19:59 ` Shubham Mishra
2022-02-23 12:08 ` [PATCH v2 0/2] " Shubham Mishra
2022-02-23 13:19 ` Shaoxuan Yuan
2022-02-23 18:01 ` Taylor Blau
2022-02-23 20:04 ` Shubham Mishra
2022-02-24 3:43 ` [PATCH 0/2] microproject: avoid using pipes in test Christian Couder
2022-02-24 5:22 ` Shubham Mishra
2022-02-24 9:29 ` Christian Couder
2022-02-24 10:13 ` Shubham Mishra
2022-02-24 18:22 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfs9thq7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=shivam828787@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).