From: Shubham Mishra <shivam828787@gmail.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 1/2] t0001: remove pipes
Date: Tue, 22 Feb 2022 23:46:14 +0530 [thread overview]
Message-ID: <CAC316V5CcB_UxpVYdAYZDPpY_ebauu4K23TrU1zLnTdgXg0PNQ@mail.gmail.com> (raw)
In-Reply-To: <9d08d2a6-82ed-7d6c-6a82-0e89c55bd94a@github.com>
> > pipes doesn't care about error codes and ignore them thus we should not use them in tests.
> > As an easy alternative, I am using a tmp file to write from git command so we can test the exit code.
>
> Please be careful about the length of your lines in your
> commit message. vim should auto-wrap as you write.
Oops, I mostly use Nano, I think it's time to use vim. I will take care of it.
> There are also some grammar issues, so here is an update
> to what you wrote:
>
> Pipes ignore error codes and thus we should not use them
> in tests. As an alternative, use a 'tmp' file to write the
> Git output so we can test the exit code.
Thanks for pointing this out. I will update it. I am a non-native
English speaker, and looking to improve my command in language with
time :)
> Split each part of the &&-chain across lines, like this:
>
> + find .git/worktrees -print >tmp &&
> + sort tmp >expected &&
>
> > git -C ../linked-worktree init &&
> > test_cmp expected-exclude .git/info/exclude &&
> > test_cmp expected-config .git/config &&
> > - find .git/worktrees -print | sort >actual &&
> > + find .git/worktrees -print >tmp && sort tmp >actual &&
>
> Here, too.
>
> I could make the same comments on patch 2, but I think you
> have enough info to go on.
Sure, I get it! I will consider all these suggestions in v2.
Thanks,
Shubham
next prev parent reply other threads:[~2022-02-22 18:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 11:43 [PATCH 0/2] microproject: avoid using pipes in test Shubham Mishra
2022-02-22 11:43 ` [PATCH 1/2] t0001: remove pipes Shubham Mishra
2022-02-22 13:54 ` Derrick Stolee
2022-02-22 18:16 ` Shubham Mishra [this message]
2022-02-22 20:32 ` Christian Couder
2022-02-23 21:07 ` Junio C Hamano
2022-02-24 3:28 ` Christian Couder
2022-02-22 11:43 ` [PATCH 2/2] t0003: " Shubham Mishra
2022-02-22 13:50 ` [PATCH 0/2] microproject: avoid using pipes in test Derrick Stolee
2022-02-22 14:24 ` Ævar Arnfjörð Bjarmason
2022-02-22 19:12 ` Shubham Mishra
2022-02-22 19:39 ` Taylor Blau
2022-02-23 11:53 ` [PATCH v2 0/2] avoid pipes with Git on LHS Shubham Mishra
2022-02-23 11:53 ` [PATCH v2 1/2] t0001: " Shubham Mishra
2022-02-23 17:53 ` Taylor Blau
2022-02-23 18:01 ` Shubham Mishra
2022-02-23 18:02 ` Taylor Blau
2022-02-23 21:10 ` Junio C Hamano
2022-02-24 5:14 ` Shubham Mishra
2022-02-23 11:53 ` [PATCH v2 2/2] t0003: " Shubham Mishra
2022-02-23 17:54 ` Taylor Blau
2022-02-23 19:59 ` Shubham Mishra
2022-02-23 12:08 ` [PATCH v2 0/2] " Shubham Mishra
2022-02-23 13:19 ` Shaoxuan Yuan
2022-02-23 18:01 ` Taylor Blau
2022-02-23 20:04 ` Shubham Mishra
2022-02-24 3:43 ` [PATCH 0/2] microproject: avoid using pipes in test Christian Couder
2022-02-24 5:22 ` Shubham Mishra
2022-02-24 9:29 ` Christian Couder
2022-02-24 10:13 ` Shubham Mishra
2022-02-24 18:22 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC316V5CcB_UxpVYdAYZDPpY_ebauu4K23TrU1zLnTdgXg0PNQ@mail.gmail.com \
--to=shivam828787@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).