From: Shubham Mishra <shivam828787@gmail.com>
To: git@vger.kernel.org
Cc: me@ttaylorr.com, derrickstolee@github.com, avarab@gmail.com,
Shubham Mishra <shivam828787@gmail.com>
Subject: [PATCH v2 2/2] t0003: avoid pipes with Git on LHS
Date: Wed, 23 Feb 2022 17:23:47 +0530 [thread overview]
Message-ID: <20220223115347.3083-3-shivam828787@gmail.com> (raw)
In-Reply-To: <20220223115347.3083-1-shivam828787@gmail.com>
Pipes ignore error codes of LHS command and thus we should not use them
with Git in tests. As an alternative, use a 'tmp' file to write the Git
output so we can test the exit code.
Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
---
t/t0003-attributes.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh
index b9ed612af1..143f100517 100755
--- a/t/t0003-attributes.sh
+++ b/t/t0003-attributes.sh
@@ -205,15 +205,18 @@ test_expect_success 'attribute test: read paths from stdin' '
test_expect_success 'attribute test: --all option' '
grep -v unspecified <expect-all | sort >specified-all &&
sed -e "s/:.*//" <expect-all | uniq >stdin-all &&
- git check-attr --stdin --all <stdin-all | sort >actual &&
+ git check-attr --stdin --all <stdin-all >tmp &&
+ sort tmp >actual &&
test_cmp specified-all actual
'
test_expect_success 'attribute test: --cached option' '
- git check-attr --cached --stdin --all <stdin-all | sort >actual &&
+ git check-attr --cached --stdin --all <stdin-all >tmp &&
+ sort tmp >actual &&
test_must_be_empty actual &&
git add .gitattributes a/.gitattributes a/b/.gitattributes &&
- git check-attr --cached --stdin --all <stdin-all | sort >actual &&
+ git check-attr --cached --stdin --all <stdin-all >tmp &&
+ sort tmp >actual &&
test_cmp specified-all actual
'
--
2.25.1
next prev parent reply other threads:[~2022-02-23 11:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 11:43 [PATCH 0/2] microproject: avoid using pipes in test Shubham Mishra
2022-02-22 11:43 ` [PATCH 1/2] t0001: remove pipes Shubham Mishra
2022-02-22 13:54 ` Derrick Stolee
2022-02-22 18:16 ` Shubham Mishra
2022-02-22 20:32 ` Christian Couder
2022-02-23 21:07 ` Junio C Hamano
2022-02-24 3:28 ` Christian Couder
2022-02-22 11:43 ` [PATCH 2/2] t0003: " Shubham Mishra
2022-02-22 13:50 ` [PATCH 0/2] microproject: avoid using pipes in test Derrick Stolee
2022-02-22 14:24 ` Ævar Arnfjörð Bjarmason
2022-02-22 19:12 ` Shubham Mishra
2022-02-22 19:39 ` Taylor Blau
2022-02-23 11:53 ` [PATCH v2 0/2] avoid pipes with Git on LHS Shubham Mishra
2022-02-23 11:53 ` [PATCH v2 1/2] t0001: " Shubham Mishra
2022-02-23 17:53 ` Taylor Blau
2022-02-23 18:01 ` Shubham Mishra
2022-02-23 18:02 ` Taylor Blau
2022-02-23 21:10 ` Junio C Hamano
2022-02-24 5:14 ` Shubham Mishra
2022-02-23 11:53 ` Shubham Mishra [this message]
2022-02-23 17:54 ` [PATCH v2 2/2] t0003: " Taylor Blau
2022-02-23 19:59 ` Shubham Mishra
2022-02-23 12:08 ` [PATCH v2 0/2] " Shubham Mishra
2022-02-23 13:19 ` Shaoxuan Yuan
2022-02-23 18:01 ` Taylor Blau
2022-02-23 20:04 ` Shubham Mishra
2022-02-24 3:43 ` [PATCH 0/2] microproject: avoid using pipes in test Christian Couder
2022-02-24 5:22 ` Shubham Mishra
2022-02-24 9:29 ` Christian Couder
2022-02-24 10:13 ` Shubham Mishra
2022-02-24 18:22 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223115347.3083-3-shivam828787@gmail.com \
--to=shivam828787@gmail.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).