git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
To: Shubham Mishra <shivam828787@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] avoid pipes with Git on LHS
Date: Wed, 23 Feb 2022 21:19:23 +0800	[thread overview]
Message-ID: <CAJyCBOTiWxAgkZPB6M5jPw=t=32zrnNH5tfnOc9Kdj9mKayrSA@mail.gmail.com> (raw)
In-Reply-To: <CAC316V57tHux-+MWMJuP5wNtwYrc2AinZj+ffnoyy-aWQWDukg@mail.gmail.com>

On Wed, Feb 23, 2022 at 8:42 PM Shubham Mishra <shivam828787@gmail.com> wrote:
>
> Hi,

Hi,

> I am using mails for code review for the first time, I have some
> doubts, Can someone please clarify them? -
> 1. It looks like the cover letter (Including "Range-diff" section) is
> only for context sharing with reviewers, nothing from it gets merged
> to the "seek" or any other branch.

The cover letter stands for an introduction/summary to your patches.
You can also put helpful context in it for better understanding. According
to my knowledge, it will not be in the commit messages.

> 2. I wanted to know how the merging process takes place. Once the
> patch is accepted, do we merge all previous versions of it one after
> another or every patch is independent so we have to just merge the
> last accepted patch?

Not so sure about this question. My two cents: generally the most agreed-upon
patch will be merged, but the exact merging process could vary based
on the circumstances. Probably Junio can have a better answer to this.

> 3. How does a particular patch set is linked to its previous version?

"--in-reply-to" will do.

> I added the flag "--in-reply-to" while sending this mail but I can't
> find any linking here on the mail. Not sure If I am missing something
> here.

Just by looking at the current thread, I think you are doing it right.

Adding "--in-reply-to" to the Message-ID of your previous patch can
give you a threaded view of the patch history on the public-inbox. For
instance, by always "--in-reply-to" the first patch version ("v1"), you can
line up your patches as they are threaded on the same level. You also
can choose to always reply to the previous patch's cover letter (just an
example), so that your patch history cascades. I think you always go
the way that best illustrates the history and helps reviewers.

I'm also new to the community, that's the best I can answer.
Inaccuracies may be found above.

-- 
Thanks & Regards,
Shaoxuan

  reply	other threads:[~2022-02-23 13:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 11:43 [PATCH 0/2] microproject: avoid using pipes in test Shubham Mishra
2022-02-22 11:43 ` [PATCH 1/2] t0001: remove pipes Shubham Mishra
2022-02-22 13:54   ` Derrick Stolee
2022-02-22 18:16     ` Shubham Mishra
2022-02-22 20:32   ` Christian Couder
2022-02-23 21:07     ` Junio C Hamano
2022-02-24  3:28       ` Christian Couder
2022-02-22 11:43 ` [PATCH 2/2] t0003: " Shubham Mishra
2022-02-22 13:50 ` [PATCH 0/2] microproject: avoid using pipes in test Derrick Stolee
2022-02-22 14:24 ` Ævar Arnfjörð Bjarmason
2022-02-22 19:12   ` Shubham Mishra
2022-02-22 19:39   ` Taylor Blau
2022-02-23 11:53 ` [PATCH v2 0/2] avoid pipes with Git on LHS Shubham Mishra
2022-02-23 11:53   ` [PATCH v2 1/2] t0001: " Shubham Mishra
2022-02-23 17:53     ` Taylor Blau
2022-02-23 18:01       ` Shubham Mishra
2022-02-23 18:02         ` Taylor Blau
2022-02-23 21:10     ` Junio C Hamano
2022-02-24  5:14       ` Shubham Mishra
2022-02-23 11:53   ` [PATCH v2 2/2] t0003: " Shubham Mishra
2022-02-23 17:54     ` Taylor Blau
2022-02-23 19:59       ` Shubham Mishra
2022-02-23 12:08   ` [PATCH v2 0/2] " Shubham Mishra
2022-02-23 13:19     ` Shaoxuan Yuan [this message]
2022-02-23 18:01       ` Taylor Blau
2022-02-23 20:04         ` Shubham Mishra
2022-02-24  3:43 ` [PATCH 0/2] microproject: avoid using pipes in test Christian Couder
2022-02-24  5:22   ` Shubham Mishra
2022-02-24  9:29     ` Christian Couder
2022-02-24 10:13       ` Shubham Mishra
2022-02-24 18:22         ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJyCBOTiWxAgkZPB6M5jPw=t=32zrnNH5tfnOc9Kdj9mKayrSA@mail.gmail.com' \
    --to=shaoxuan.yuan02@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=shivam828787@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).