git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH v3] build: add default aliases
Date: Thu, 17 Oct 2013 12:51:13 -0700	[thread overview]
Message-ID: <xmqqppr3znf1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: 525e0b6e25aeb_81a151de7495@nysa.notmuch

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:
>> 
>> > It seems[1] that some
>> > people define "ci" as "commit -a", and some people define "st" as
>> > "status -s" or even "status -sb".
>> 
>> These option variants aside.
>> 
>> Just like thinking that committing must be the same as publishing,
>> it is a cvs/svn induced braindamage to think that "checking in" must
>> be the same as "committing".  The former is a sign of not
>> understanding the "distributed", the latter "the index".
>> 
>> In a world with both check-in and commit as two words usable to
>> denote possibly different concepts, it may make sense to say "you
>> check-in the current status of the working tree files into the
>> index, in order to make commits out of it later".
>
> Yet a wide amount of users do use 'ci' to mean 'commit', so basically they are
> just wrong. So you are saying they are just ignorant.

I am sick of seeing my word twisted, especially when they were not
even addressed to you (see the message's primary recipients list).
Those who want to type "git ci" due to their familiarity with "svn
ci" are not wrong; they can do so if they choose.

Let's try again (see below).

> Now, if you are commenting on the aliases, that would mean you are not against
> the idea of aliaes per se, but more about values of those aliases. So if we
> agreed on the right values, you would welcome this patch.
>
> Is that correct?

No.

I agree with the issue the message I was replying to raised. The
alias mechanism is a way to help users to define their own
convenient short-cut. If you want to say "git ci" to mean "git
commit" (and not "git commit -a" or something else), define it for
your own use, and stop there, without getting in the way of other
people. That is why I see an attempt to add hard-coded set of
aliases as a move in the wrong direction.

A set of hard-coded alias that _officially_ declares that "checkin"
is an equivalent to "commit" has another issue.  It will close the
door for us to later add "git checkin" that may mean something
different from "git commit", and that is another reason why I do not
agree with the patch under discussion in this thread. A "checkin"
that is an operation that checks-in the current contents to the
index is one example of an action other than committing that the
word may make sense for, because "git checkout README.txt" is about
checking out of the index, its logical opposite "checkin" could be
about checking into the index.

  reply	other threads:[~2013-10-17 19:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 19:20 [PATCH v3] build: add default aliases Felipe Contreras
2013-09-24  4:53 ` Jeff King
2013-09-24  5:32   ` Felipe Contreras
2013-09-24  5:37     ` Jeff King
2013-09-24  5:49       ` Felipe Contreras
2013-09-24  6:18         ` Jeff King
2013-09-24  6:41           ` Felipe Contreras
2013-09-24  6:46             ` Jeff King
2013-09-24  6:59               ` Felipe Contreras
2013-09-24 18:39   ` Jonathan Nieder
2013-09-24 19:30     ` John Szakmeister
2013-09-28 22:41     ` Felipe Contreras
2013-09-29  3:18       ` Michael Haggerty
2013-09-29  3:37         ` Felipe Contreras
2013-09-30 19:33         ` Jonathan Nieder
2013-10-01  1:12           ` Duy Nguyen
2013-10-15 22:34   ` Junio C Hamano
2013-10-16  3:43     ` Felipe Contreras
2013-10-17 19:51       ` Junio C Hamano [this message]
2013-10-17 21:34         ` Felipe Contreras
2013-09-24  9:19 ` John Szakmeister
2013-09-24 10:25   ` Felipe Contreras
2013-09-24 11:06     ` John Szakmeister
2013-09-24 14:35       ` Felipe Contreras
2013-09-25 13:33         ` John Szakmeister
2013-09-25 14:29           ` Felipe Contreras
2013-09-25 14:55             ` Matthieu Moy
2013-09-25 15:08               ` Felipe Contreras
2013-09-25 15:13                 ` Matthieu Moy
2013-09-25 15:16                   ` Felipe Contreras
2013-09-25 16:05                     ` Matthieu Moy
2013-09-25 16:36                       ` Felipe Contreras
2013-09-24 15:21 ` SZEDER Gábor
2013-09-24 15:33   ` [PATCH v4] " Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqppr3znf1.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=davvid@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).