git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: John Szakmeister <john@szakmeister.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH v3] build: add default aliases
Date: Tue, 24 Sep 2013 15:30:12 -0400	[thread overview]
Message-ID: <CAEBDL5Xa2C_zXdaE+Db9Rh7o_xyF6gC-72_Nxb0u5_o4ACjuFw@mail.gmail.com> (raw)
In-Reply-To: <20130924183958.GK9464@google.com>

On Tue, Sep 24, 2013 at 2:39 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Jeff King wrote:
>> On Sat, Sep 21, 2013 at 02:20:21PM -0500, Felipe Contreras wrote:
>
>>> For now simply add a few common aliases.
>>>
>>>   co = checkout
>>>   ci = commit
>>>   rb = rebase
>>>   st = status
>>
>> Are these the best definitions of those shortcuts? It seems[1] that some
>> people define "ci" as "commit -a", and some people define "st" as
>> "status -s" or even "status -sb".
>
> I feel bad about having waited for 4 rounds of this patch to say this,
> but the basic change (providing "co", "ci", etc. as aliases by
> default) does not look well thought through.
>
> It would be a different story if this were a patch to update
> documentation to suggest adding such aliases at the same time as
> telling Git what your name is.  The user manual doesn't explain how to
> set up aliases at all yet, and that should be fixed.

Yes, better documentation around aliases would be a good idea.

> But making 'ci' a synonym of another command by default while still
> keeping its definition configurable would be doing people a
> disservice, I fear.  As long as 'ci' works out of the box, it will
> start showing up in examples and used in suggestions over IRC, etc,
> which is great.  Unfortunately that means that anyone who has 'ci'
> defined to mean something different can no longer use those examples,
> that advice from IRC, and so on.  So in the world where 'ci' is a
> synonym for 'commit' by default, while people still *can* redefine
> 'ci' to include whatever options they like (e.g., "-a"), actually
> carrying out such a personal customization is asking for trouble.

I'm not sure I agree.  Yes, if someone has configured their shortcut
differently, they may not be able to use the example exactly.  OTOH,
shells have aliases, and while there are sometimes problems, I think
most people overcome them.  I don't see the situation being very
different here.

FWIW, I'm not overly convinced one way or another.  What I can say is,
in the circles I run in, I can only think of one person has gone
without setting up aliases to commit (ci), status (st), and checkout
(co).  The full names are simply to long for day-to-day usage.

-John

  reply	other threads:[~2013-09-24 19:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 19:20 [PATCH v3] build: add default aliases Felipe Contreras
2013-09-24  4:53 ` Jeff King
2013-09-24  5:32   ` Felipe Contreras
2013-09-24  5:37     ` Jeff King
2013-09-24  5:49       ` Felipe Contreras
2013-09-24  6:18         ` Jeff King
2013-09-24  6:41           ` Felipe Contreras
2013-09-24  6:46             ` Jeff King
2013-09-24  6:59               ` Felipe Contreras
2013-09-24 18:39   ` Jonathan Nieder
2013-09-24 19:30     ` John Szakmeister [this message]
2013-09-28 22:41     ` Felipe Contreras
2013-09-29  3:18       ` Michael Haggerty
2013-09-29  3:37         ` Felipe Contreras
2013-09-30 19:33         ` Jonathan Nieder
2013-10-01  1:12           ` Duy Nguyen
2013-10-15 22:34   ` Junio C Hamano
2013-10-16  3:43     ` Felipe Contreras
2013-10-17 19:51       ` Junio C Hamano
2013-10-17 21:34         ` Felipe Contreras
2013-09-24  9:19 ` John Szakmeister
2013-09-24 10:25   ` Felipe Contreras
2013-09-24 11:06     ` John Szakmeister
2013-09-24 14:35       ` Felipe Contreras
2013-09-25 13:33         ` John Szakmeister
2013-09-25 14:29           ` Felipe Contreras
2013-09-25 14:55             ` Matthieu Moy
2013-09-25 15:08               ` Felipe Contreras
2013-09-25 15:13                 ` Matthieu Moy
2013-09-25 15:16                   ` Felipe Contreras
2013-09-25 16:05                     ` Matthieu Moy
2013-09-25 16:36                       ` Felipe Contreras
2013-09-24 15:21 ` SZEDER Gábor
2013-09-24 15:33   ` [PATCH v4] " Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEBDL5Xa2C_zXdaE+Db9Rh7o_xyF6gC-72_Nxb0u5_o4ACjuFw@mail.gmail.com \
    --to=john@szakmeister.net \
    --cc=davvid@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).