From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH v3] build: add default aliases
Date: Tue, 24 Sep 2013 01:37:12 -0400 [thread overview]
Message-ID: <20130924053712.GA6114@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMP44s1tirA5w91L2YomaduZVkqL3=n1j79eoueB6XeGuyY3Mw@mail.gmail.com>
On Tue, Sep 24, 2013 at 12:32:46AM -0500, Felipe Contreras wrote:
> > You are making things more consistent for people who already define
> > those aliases in the same way (they are available everywhere, even if
> > they have not moved their config to a new installation), but less so for
> > people who define them differently. Rather than get an obvious:
> >
> > git: 'co' is not a git command. See 'git --help'.
> >
> > the result will be subtly different (especially so in the case of
> > "commit" versus "commit -a").
>
> Before:
>
> # machine A: git ci
> git: 'ca' is not a git command. See 'git --help'.
>
> # machine B: git ci
> commits
>
> After:
>
> # machine A: git ci
> no changes added to commit (use "git add" and/or "git commit -a")
>
> # machine B: git ci
> commits
That is the output if there are no files to commit. What about while
resolving a merge, or after using "git add" on a path? In that case we
create a commit, but it is subtly different than what the user intended.
I think for the merge case, it is probably OK, as the "surprise" should
always go in the safe direction (user expects "commit -a", gets
"commit", and commit balks). But the other omits intended files from the
commit.
-Peff
next prev parent reply other threads:[~2013-09-24 5:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 19:20 [PATCH v3] build: add default aliases Felipe Contreras
2013-09-24 4:53 ` Jeff King
2013-09-24 5:32 ` Felipe Contreras
2013-09-24 5:37 ` Jeff King [this message]
2013-09-24 5:49 ` Felipe Contreras
2013-09-24 6:18 ` Jeff King
2013-09-24 6:41 ` Felipe Contreras
2013-09-24 6:46 ` Jeff King
2013-09-24 6:59 ` Felipe Contreras
2013-09-24 18:39 ` Jonathan Nieder
2013-09-24 19:30 ` John Szakmeister
2013-09-28 22:41 ` Felipe Contreras
2013-09-29 3:18 ` Michael Haggerty
2013-09-29 3:37 ` Felipe Contreras
2013-09-30 19:33 ` Jonathan Nieder
2013-10-01 1:12 ` Duy Nguyen
2013-10-15 22:34 ` Junio C Hamano
2013-10-16 3:43 ` Felipe Contreras
2013-10-17 19:51 ` Junio C Hamano
2013-10-17 21:34 ` Felipe Contreras
2013-09-24 9:19 ` John Szakmeister
2013-09-24 10:25 ` Felipe Contreras
2013-09-24 11:06 ` John Szakmeister
2013-09-24 14:35 ` Felipe Contreras
2013-09-25 13:33 ` John Szakmeister
2013-09-25 14:29 ` Felipe Contreras
2013-09-25 14:55 ` Matthieu Moy
2013-09-25 15:08 ` Felipe Contreras
2013-09-25 15:13 ` Matthieu Moy
2013-09-25 15:16 ` Felipe Contreras
2013-09-25 16:05 ` Matthieu Moy
2013-09-25 16:36 ` Felipe Contreras
2013-09-24 15:21 ` SZEDER Gábor
2013-09-24 15:33 ` [PATCH v4] " Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924053712.GA6114@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=davvid@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).