git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] revisions.txt: expand tabs to spaces in diagram
Date: Fri, 04 May 2018 11:32:03 +0900	[thread overview]
Message-ID: <xmqqmuxgtal8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180504015202.GP13217@genre.crustytoothpaste.net> (brian m. carlson's message of "Fri, 4 May 2018 01:52:02 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> ...  We can help both AsciiDoc and Asciidoctor do the right thing
> here (and keep our 8-space tabs) by enclosing the diagram in a block
> like so:
>
> [literal]
> --
>    Args   Expanded arguments    Selected commits
>    D                            G H D
>    D F                          G H I J D F
>    ...
> 	  = B ^D ^E ^F          B
>    F^! D  = F ^I ^J D           G H D F
> --
>
> and using the tabsize=8 attribute when invoking Asciidoctor.  I can send
> a patch tomorrow which does this, which I think may be a bit nicer than
> having to give up tabs.

Yeah, trying to forbid indent-with-tab has been shown to be
unworkable so even if we tried to give up tabs, it is likely we
would break it by mistake.  Allowing indent-with-tab and ask the
tool to do the right thing is obviously the right direction.

Thanks.

  reply	other threads:[~2018-05-04  2:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 21:04 [PATCH] revisions.txt: expand tabs to spaces in diagram Martin Ågren
2018-05-02  4:50 ` Junio C Hamano
2018-05-02  6:20   ` Martin Ågren
2018-05-04  1:52     ` brian m. carlson
2018-05-04  2:32       ` Junio C Hamano [this message]
2018-05-06 20:42       ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor brian m. carlson
2018-05-06 20:42         ` [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor brian m. carlson
2018-05-07  4:11           ` Martin Ågren
2018-05-08  1:13             ` brian m. carlson
2018-05-08 18:31               ` Martin Ågren
2018-05-09  0:24                 ` brian m. carlson
2018-05-07  3:04         ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmuxgtal8.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).