From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] revisions.txt: expand tabs to spaces in diagram
Date: Wed, 02 May 2018 13:50:34 +0900 [thread overview]
Message-ID: <xmqq7eomwtid.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180430210430.14611-1-martin.agren@gmail.com> ("Martin Ågren"'s message of "Mon, 30 Apr 2018 23:04:30 +0200")
Martin Ågren <martin.agren@gmail.com> writes:
> The diagram renders fine in AsciiDoc before and after this patch.
> Asciidoctor, on the other hand, ignores the tabs entirely, which results
> in different indentation for different lines. The graph illustration
> earlier in the document already uses spaces instead of a tab.
Ouch. We might want to teach Documentation/.gitattributes that
indent-with-tab is unwelcome in that directory, after making this
fix (and possibly similar ones to other files).
next prev parent reply other threads:[~2018-05-02 4:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 21:04 [PATCH] revisions.txt: expand tabs to spaces in diagram Martin Ågren
2018-05-02 4:50 ` Junio C Hamano [this message]
2018-05-02 6:20 ` Martin Ågren
2018-05-04 1:52 ` brian m. carlson
2018-05-04 2:32 ` Junio C Hamano
2018-05-06 20:42 ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor brian m. carlson
2018-05-06 20:42 ` [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor brian m. carlson
2018-05-07 4:11 ` Martin Ågren
2018-05-08 1:13 ` brian m. carlson
2018-05-08 18:31 ` Martin Ågren
2018-05-09 0:24 ` brian m. carlson
2018-05-07 3:04 ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7eomwtid.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).