mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Martin Ågren" <>
To: "brian m. carlson" <>,
	"Martin Ågren" <>,
	"Git Mailing List" <>,
	"Junio C Hamano" <>
Subject: Re: [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor
Date: Tue, 8 May 2018 20:31:10 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 8 May 2018 at 03:13, brian m. carlson <> wrote:
> On Mon, May 07, 2018 at 06:11:43AM +0200, Martin Ågren wrote:
>> Excellent. These two patches fix my original problem and seem like the
>> obviously correct approach (in hindsight ;-) ). I wonder if the diagrams
>> earlier in the file should be tackled also. Right now, one has a huge
>> number of dots instead of the four you added; the other has none. They
>> do render fine though, so that'd only be about consistency in the
>> original .txt-file.
> Yeah, the number of dots has to be at least four, but can be any
> matching number.
> Since this patch fixes the present issue, I'd like to leave it as it is
> and run through a cleanup series a bit later that catches all the
> literal indented blocks and marks them explicitly to avoid this issue in
> the future.

Sounds like a plan. :-) As noted elsewhere, I have no immediate idea how
to identify which of the 13000 tab-indented lines are really part of
diagrams and ascii-art. Counting the number of spaces? Anyway, thanks
for this mini-series.


  reply	other threads:[~2018-05-08 18:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 21:04 [PATCH] revisions.txt: expand tabs to spaces in diagram Martin Ågren
2018-05-02  4:50 ` Junio C Hamano
2018-05-02  6:20   ` Martin Ågren
2018-05-04  1:52     ` brian m. carlson
2018-05-04  2:32       ` Junio C Hamano
2018-05-06 20:42       ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor brian m. carlson
2018-05-06 20:42         ` [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor brian m. carlson
2018-05-07  4:11           ` Martin Ågren
2018-05-08  1:13             ` brian m. carlson
2018-05-08 18:31               ` Martin Ågren [this message]
2018-05-09  0:24                 ` brian m. carlson
2018-05-07  3:04         ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).