From: "Martin Ågren" <martin.agren@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor
Date: Mon, 7 May 2018 06:11:43 +0200 [thread overview]
Message-ID: <CAN0heSrth+ZheEsHuVdyUv9fcnP07O=YvK6y+=rmaGqZf7X3_w@mail.gmail.com> (raw)
In-Reply-To: <20180506204226.955739-2-sandals@crustytoothpaste.net>
On 6 May 2018 at 22:42, brian m. carlson <sandals@crustytoothpaste.net> wrote:
> When creating a literal block from an indented block without any sort of
> delimiters, Asciidoctor strips off all leading whitespace, resulting in
> a misrendered chart. Use an explicit literal block to indicate to
> Asciidoctor that we want to keep the leading whitespace.
Excellent. These two patches fix my original problem and seem like the
obviously correct approach (in hindsight ;-) ). I wonder if the diagrams
earlier in the file should be tackled also. Right now, one has a huge
number of dots instead of the four you added; the other has none. They
do render fine though, so that'd only be about consistency in the
original .txt-file.
next prev parent reply other threads:[~2018-05-07 4:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 21:04 [PATCH] revisions.txt: expand tabs to spaces in diagram Martin Ågren
2018-05-02 4:50 ` Junio C Hamano
2018-05-02 6:20 ` Martin Ågren
2018-05-04 1:52 ` brian m. carlson
2018-05-04 2:32 ` Junio C Hamano
2018-05-06 20:42 ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor brian m. carlson
2018-05-06 20:42 ` [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor brian m. carlson
2018-05-07 4:11 ` Martin Ågren [this message]
2018-05-08 1:13 ` brian m. carlson
2018-05-08 18:31 ` Martin Ågren
2018-05-09 0:24 ` brian m. carlson
2018-05-07 3:04 ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSrth+ZheEsHuVdyUv9fcnP07O=YvK6y+=rmaGqZf7X3_w@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).