From: Junio C Hamano <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: Christian Couder <email@example.com>, Anders Waldenborg <firstname.lastname@example.org>, git <email@example.com>, Jonathan Tan <firstname.lastname@example.org> Subject: Re: Questions about trailer configuration semantics Date: Tue, 28 Jul 2020 09:40:40 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20200728154132.GA817108@coredump.intra.peff.net> (Jeff King's message of "Tue, 28 Jul 2020 11:41:32 -0400") Jeff King <firstname.lastname@example.org> writes: > It's inevitable that you'll have to do some data cleanup like that > anyway. Lumping together prefixes isn't flexible enough to coverall > cases. Using trailer.*.key to manually map names covers more, but again > not all (e.g., if the project used to use "foo" but switched to "bar", > but the syntax of the value fields also changed at the same time, you'd > need to normalize those, too). > > So to me it boils down to: > > - returning the data as verbatim as possible when reading existing > trailers would give the least surprise to most people > > - real data collection is going to involve a separate post-processing > step which is better done in a full programming language Yeah, I agree that these are good guidelines to use when we think about the feature. > The original %(trailers) was "dump the trailers block verbatim". But > that's not super useful for parsing individual trailers. So "only" > actually starts parsing the individual trailers. I'd argue that the > %(trailers) behavior is correct, but that %(trailers:only) should > probably be doing less (i.e., just parsing and reporting what it finds, > but not changing any names). Yes, sounds sensible.
prev parent reply other threads:[~2020-07-28 16:41 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-27 16:45 Anders Waldenborg 2020-07-27 17:18 ` Junio C Hamano 2020-07-27 18:37 ` Christian Couder 2020-07-27 19:40 ` Jeff King 2020-07-27 22:57 ` Anders Waldenborg 2020-07-27 23:42 ` Jeff King 2020-07-27 20:11 ` Junio C Hamano 2020-07-27 22:17 ` Anders Waldenborg 2020-07-27 23:05 ` Junio C Hamano 2020-07-28 0:01 ` Anders Waldenborg 2020-07-27 21:41 ` Anders Waldenborg 2020-07-27 22:53 ` Junio C Hamano 2020-07-27 23:17 ` Anders Waldenborg 2020-07-28 7:07 ` Christian Couder 2020-07-28 15:41 ` Jeff King 2020-07-28 16:40 ` Junio C Hamano [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Questions about trailer configuration semantics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).