From: Jeff King <firstname.lastname@example.org> To: Christian Couder <email@example.com> Cc: Junio C Hamano <firstname.lastname@example.org>, git <email@example.com>, Anders Waldenborg <firstname.lastname@example.org>, Jonathan Tan <email@example.com> Subject: Re: Questions about trailer configuration semantics Date: Mon, 27 Jul 2020 15:40:36 -0400 [thread overview] Message-ID: <20200727194036.GA795313@coredump.intra.peff.net> (raw) In-Reply-To: <CAP8UFD1XV_jN10yOc2o4=5PtPcvT-RbxhY1H3swZz2r4g-Uzkw@mail.gmail.com> On Mon, Jul 27, 2020 at 08:37:26PM +0200, Christian Couder wrote: > > > I noticed some undocumented and (at least to me) surprising behavior in > > > trailers.c. > > > > > > When configuring a value in trailer.<token>.key it causes the trailer to > > > be normalized to that in "git interpret-trailers --parse". > > > E.g: > > > $ printf '\naCKed: Zz\n' | \ > > > git -c 'trailer.Acked.key=Acked' interpret-trailers --parse > > > will emit: "Acked: Zz" > > Yeah, I think that's nice, as it can make sure that the key appears in > the same way. It's true that it would be better if it would be > documented. I'd note that this also happens without --parse. > > > Then there is the replacement by config "trailer.fix.key=Fixes" which > > > expands "fix" to "Fixes". This happens when using "--trailer 'fix = 123'" > > > which seems to be expected and useful behavior (albeit a bit unclear in > > > documentation). But it also happens when parsing incoming trailers, e.g > > > with that config > > > $ printf "\nFix: 1\n" | git interpret-trailers --parse > > > will emit: "Fixes: 1" > [...] > > > * Should replacement to what is in .key happen also in --parse mode, or > > > only for "--trailer" > > I think it's more consistent if it happens in both --parse and > --trailer mode. I didn't implement --parse though. I don't recall being aware of this prefix matching until this thread, so I doubt that the current behavior of --parse was something I tried for intentionally. It's mostly just using the existing code, plus a few extra options (listed in the docs). I'm not opposed to adding an option to do strict matching and/or avoid rewriting, and then possibly adding that into --parse by default. I don't have much of an opinion on which behavior would be preferred. I've never actually had a use case for configuring trailer.*.key, as I usually am only looking at reading existing trailers to collect stats, etc. -Peff
next prev parent reply other threads:[~2020-07-27 19:40 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-27 16:45 Anders Waldenborg 2020-07-27 17:18 ` Junio C Hamano 2020-07-27 18:37 ` Christian Couder 2020-07-27 19:40 ` Jeff King [this message] 2020-07-27 22:57 ` Anders Waldenborg 2020-07-27 23:42 ` Jeff King 2020-07-27 20:11 ` Junio C Hamano 2020-07-27 22:17 ` Anders Waldenborg 2020-07-27 23:05 ` Junio C Hamano 2020-07-28 0:01 ` Anders Waldenborg 2020-07-27 21:41 ` Anders Waldenborg 2020-07-27 22:53 ` Junio C Hamano 2020-07-27 23:17 ` Anders Waldenborg 2020-07-28 7:07 ` Christian Couder 2020-07-28 15:41 ` Jeff King 2020-07-28 16:40 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200727194036.GA795313@coredump.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Questions about trailer configuration semantics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).