From: Anders Waldenborg <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: Christian Couder <firstname.lastname@example.org>, git <email@example.com>, Jeff King <firstname.lastname@example.org>, Jonathan Tan <email@example.com> Subject: Re: Questions about trailer configuration semantics Date: Tue, 28 Jul 2020 02:01:15 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Junio C Hamano writes: > Anders Waldenborg <firstname.lastname@example.org> writes: > >> From what I can understand it tries to match *both* on the second level >> AND the value of .key (trailers.c:token_matches_item) > > Yuck, I do not know what were we thinking to design the behaviour > like *that*. Or it may be simply buggy. > >> $ printf '\na: 1\nb: 2\nc: 3\n' | \ >> git -c 'trailer.A.key=B' interpret-trailers >> B: 1 >> B: 2 >> c: 3 > > I can understand the first one (i.e. "trailer.$name.$var" try to > match $name as case insensitively) but not the second one. There is > not an single rule for "b" trailer, and we should be getting the > same behaviour as the third line, i.e. the key not involved in > rewriting is passed as-is. I'm not so sure about that. Matching sometimes needs to happen on .key too. If this configuration is supposed to be useful (and as "shortcuts" has been mentioned before and is what tests does, I think it should be): trailer.rb.key=Reviewed-By trailer.rb.ifexists=addifdifferent then matching must look at key, not name. As the value of .key is what would have been written previously into the message. E.g: $ printf "\nReviewed-By: hi\n" | \ git -c "trailer.rb.key=Reviewed-By" \ -c "trailer.rb.ifexists=addifdifferent" \ interpret-trailers --trailer "rb=hi" Reviewed-By: hi The opposite case, matching on name in input message I'm not sure where it is useful. $ printf "\nrb: hi\n" | \ git -c "trailer.rb.key=Reviewed-By" \ -c "trailer.rb.ifexists=addifdifferent" \ interpret-trailers --trailer "rb=hi" Reviewed-By: hi The way I have understood it ".key" can be used for some different things: * Freeing up name to be used as a shortcut alias. * Defining the canonical capitalization when passing through trailers * Allowing specifying non default separator for that key. I wonder if those uses could be split up. So instead of this configuration: [trailer "rb"] key="Reviewed-By> " that does all three of those. The configuration would be: [trailer "Reviewed-By"] separator="> " canonicalize=true alias=rb that way the "name" part of the config always is the correct spelling and capitalization. "alias" could easily be a list of multiple alias if that is wanted. "alias" could be split into "inputalias" (matched against when reading trailers from stdin or a commit/tag message) and "optalias" (matched against when reading --trailer cmdline option, and %(trailers:key))
next prev parent reply other threads:[~2020-07-28 0:01 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-27 16:45 Anders Waldenborg 2020-07-27 17:18 ` Junio C Hamano 2020-07-27 18:37 ` Christian Couder 2020-07-27 19:40 ` Jeff King 2020-07-27 22:57 ` Anders Waldenborg 2020-07-27 23:42 ` Jeff King 2020-07-27 20:11 ` Junio C Hamano 2020-07-27 22:17 ` Anders Waldenborg 2020-07-27 23:05 ` Junio C Hamano 2020-07-28 0:01 ` Anders Waldenborg [this message] 2020-07-27 21:41 ` Anders Waldenborg 2020-07-27 22:53 ` Junio C Hamano 2020-07-27 23:17 ` Anders Waldenborg 2020-07-28 7:07 ` Christian Couder 2020-07-28 15:41 ` Jeff King 2020-07-28 16:40 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Questions about trailer configuration semantics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).