From: Anders Waldenborg <anders@0x63.nu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: Questions about trailer configuration semantics
Date: Tue, 28 Jul 2020 00:17:39 +0200 [thread overview]
Message-ID: <878sf4r4au.fsf@0x63.nu> (raw)
In-Reply-To: <xmqqk0yog1lg.fsf@gitster.c.googlers.com>
Junio C Hamano writes:
> Christian Couder <christian.couder@gmail.com> writes:
>> Yeah, in this case we are not sure if "Acked" or "aCKed" is the right
>> way to spell it.
>
> OK, so in short, the trailer subsystem matches the second level of
> the configuration variable name (e.g. "Acked") in a case insensitive
> way
From what I can understand it tries to match *both* on the second level
AND the value of .key (trailers.c:token_matches_item)
$ printf '\na: 1\nb: 2\nc: 3\n' | \
git -c 'trailer.A.key=B' interpret-trailers
B: 1
B: 2
c: 3
and then uses the .key value when outputting the result (by calling
trailer.c:token_from_item)
I.e:
it gets "a: 1", tries to find configuration for that, and finds
trailer.A because "a" (case insenitively) matches conf.name, therefore
it outputs value of trailer.A.key + separator + "1"
then it gets "b: 1", and again finds trailer.A because "b" matches
conf.key.
> , and it does *not* normalize the case in the output. The .key
> request is a mechanism to replace the matched key with the specified
> string, so there is *NO* case normalization in what Anders observed.
Hmm. Maybe the "matching" vs "outputting" makes it clearer.
Given configuration trailer.<NAME>.key=<KEY>
When printing a parsed trailer, e.g from pretty format "%(trailers)",
"git interpret-trailers" passthrough of existing trailers or addition of
a new trailer with --trailer: <KEY> is used in output. If <KEY> is not
configured the trailer token is output the same way as it was in input.
When finding a trailer, e.g for '--trailer x=y' or
trailer.<NAME>.where=before/after: matching is done against both
<NAME> and <KEY>.
When showing a single trailer with pretty format '%(trailers:key=X)' it
is matched against <KEY> only. (I guess one can see this as matching on
the formatted output).
> In other words,
>
> $ printf '\naCKed: Zz\n' | \
> git -c 'trailer.Acked.key=Rejected' interpret-trailers --parse
>
> would have emitted "Rejected: Zz".
Indeed.
next prev parent reply other threads:[~2020-07-27 22:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 16:45 Questions about trailer configuration semantics Anders Waldenborg
2020-07-27 17:18 ` Junio C Hamano
2020-07-27 18:37 ` Christian Couder
2020-07-27 19:40 ` Jeff King
2020-07-27 22:57 ` Anders Waldenborg
2020-07-27 23:42 ` Jeff King
2020-07-27 20:11 ` Junio C Hamano
2020-07-27 22:17 ` Anders Waldenborg [this message]
2020-07-27 23:05 ` Junio C Hamano
2020-07-28 0:01 ` Anders Waldenborg
2020-07-27 21:41 ` Anders Waldenborg
2020-07-27 22:53 ` Junio C Hamano
2020-07-27 23:17 ` Anders Waldenborg
2020-07-28 7:07 ` Christian Couder
2020-07-28 15:41 ` Jeff King
2020-07-28 16:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sf4r4au.fsf@0x63.nu \
--to=anders@0x63.nu \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).